From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Mon, 4 Jan 2016 20:40:42 +0100 Subject: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version In-Reply-To: References: <1449844384-6236-1-git-send-email-wdc@rock-chips.com> <566F5FAC.3080404@rock-chips.com> Message-ID: <20160104194042.GD1522@katana> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > >> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long > >> scl_rate, > >> + unsigned long scl_rise_ns, > >> + unsigned long scl_fall_ns, > >> + unsigned long sda_fall_ns, > > Wolfram did some sturct to assign the parameters from device properties. > It might be re-used here. Yes, I think it makes sense to convert the driver first to use the new i2c_parse_fw_timings() function and see if it fits (or if we need to extend it perhaps). David, does this make sense to you? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: