From: richardcochran@gmail.com (Richard Cochran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: pci: mark the dra7xx driver as broken
Date: Thu, 7 Jan 2016 10:25:53 +0100 [thread overview]
Message-ID: <20160107092553.GA7378@localhost.localdomain> (raw)
In-Reply-To: <568E2566.6000209@ti.com>
On Thu, Jan 07, 2016 at 02:14:22PM +0530, Kishon Vijay Abraham I wrote:
> In my point of view the driver is not broken as such but an independent piece
> (reset) which is missing, since this driver compiles and works fine if that
> reset piece is added. You are right in that this shouldn't have been probed
> since it's known that the reset piece is missing. Maybe we should just set
> "status = disabled" in dra7.dtsi and when that reset piece is added enable it
> back in dra7-evm.dts?
That isn't strong enough, IMHO, since status=disabled is the default
for most every DTS item. Maybe you could comment the PCI block out or
remove it and put a comment in about the missing piece and the lock up
behavior. It is really a nasty bug to have the machine freeze up with
no output at all. It took me some time to figure out what was going
on, and it would be a shame if someone else sets status=okay in their
board file and has to repeat the whole exercise.
Thanks,
Richard
next prev parent reply other threads:[~2016-01-07 9:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 21:45 dra7xx pci driver broken on dra7xx-evm Richard Cochran
2016-01-07 5:17 ` Kishon Vijay Abraham I
2016-01-07 7:37 ` Richard Cochran
2016-01-07 8:11 ` [PATCH] arm: pci: mark the dra7xx driver as broken Richard Cochran
2016-01-07 8:44 ` Kishon Vijay Abraham I
2016-01-07 9:25 ` Richard Cochran [this message]
2016-01-07 14:42 ` Bjorn Helgaas
2016-01-08 6:55 ` Kishon Vijay Abraham I
2016-01-07 21:26 ` dra7xx pci driver broken on dra7xx-evm Suman Anna
2016-01-07 21:59 ` Tony Lindgren
2016-01-08 6:07 ` Kishon Vijay Abraham I
2016-01-08 9:22 ` Richard Cochran
2016-01-11 8:58 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107092553.GA7378@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).