From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] drivers: ata: wake port before DMA stop for ALPM
Date: Sun, 10 Jan 2016 12:29:29 -0500 [thread overview]
Message-ID: <20160110172929.GK3660@htj.duckdns.org> (raw)
In-Reply-To: <5690444C.2090200@broadcom.com>
Hello, Danesh.
On Fri, Jan 08, 2016 at 03:20:44PM -0800, Danesh Petigara wrote:
> ahci_set_lpm in it's current form cannot be used here as it also
> modifies the ALPE/ASP bits. The idea is to wake the link before DMA stop
> without changing the ALPM bits so the link can return to it's configured
> low power state when it's idle.
>
> We could however update that function by introducing a new hints flag
> that allows us to skip unneeded logic for this scenario. ahci_set_lpm
> can then be called from ahci_stop_engine.
Yeah, please either update the function or factor the necessary part
out.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-01-10 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 0:03 [PATCH 0/4] ata: ahci_brcmstb: ALPM support Florian Fainelli
2016-01-08 0:03 ` [PATCH 1/4] ata: ahci_brcmstb: enable support for ALPM Florian Fainelli
2016-01-08 16:29 ` Tejun Heo
2016-01-08 0:03 ` [PATCH 2/4] ata: ahci_brcmstb: disable DIPM support Florian Fainelli
2016-01-08 16:30 ` Tejun Heo
2016-01-08 0:03 ` [PATCH 3/4] drivers: ata: wake port before DMA stop for ALPM Florian Fainelli
2016-01-08 16:36 ` Tejun Heo
2016-01-08 23:20 ` Danesh Petigara
2016-01-10 17:29 ` Tejun Heo [this message]
2016-01-08 0:03 ` [PATCH 4/4] libata: skip debounce delay on link resume Florian Fainelli
2016-01-08 16:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110172929.GK3660@htj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).