* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
@ 2016-01-10 12:40 Mans Rullgard
2016-01-10 13:08 ` Stefan Wahren
0 siblings, 1 reply; 8+ messages in thread
From: Mans Rullgard @ 2016-01-10 12:40 UTC (permalink / raw)
To: linux-arm-kernel
Add pinmux setting for USB1 overcurrent on pwm2 pad.
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
arch/arm/boot/dts/imx28.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index fae7b9069fc4..2f5cbf7d09f2 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -883,6 +883,16 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
+ usb1_pins_b: usb1 at 1 {
+ reg = <1>;
+ fsl,pinmux-ids = <
+ MX28_PAD_PWM2__USB1_OVERCURRENT
+ >;
+ fsl,drive-strength = <MXS_DRIVE_12mA>;
+ fsl,voltage = <MXS_VOLTAGE_HIGH>;
+ fsl,pull-up = <MXS_PULL_DISABLE>;
+ };
+
usb0_id_pins_a: usb0id at 0 {
reg = <0>;
fsl,pinmux-ids = <
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 12:40 [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Mans Rullgard
@ 2016-01-10 13:08 ` Stefan Wahren
2016-01-10 13:13 ` Måns Rullgård
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Wahren @ 2016-01-10 13:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mans,
> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>
>
> Add pinmux setting for USB1 overcurrent on pwm2 pad.
could you please change your patch to describe why you need to add this pinmux?
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
Thanks Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:08 ` Stefan Wahren
@ 2016-01-10 13:13 ` Måns Rullgård
2016-01-10 13:38 ` Stefan Wahren
0 siblings, 1 reply; 8+ messages in thread
From: Måns Rullgård @ 2016-01-10 13:13 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Hi Mans,
>
>> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>>
>>
>> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>
> could you please change your patch to describe why you need to add
> this pinmux?
I'm working on a board that is wired that way. I can of course put this
in the board-specific dts if that's preferable.
--
M?ns Rullg?rd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:13 ` Måns Rullgård
@ 2016-01-10 13:38 ` Stefan Wahren
2016-01-10 13:42 ` Måns Rullgård
2016-01-10 19:01 ` Uwe Kleine-König
0 siblings, 2 replies; 8+ messages in thread
From: Stefan Wahren @ 2016-01-10 13:38 UTC (permalink / raw)
To: linux-arm-kernel
> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
> > Hi Mans,
> >
> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> >>
> >>
> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >
> > could you please change your patch to describe why you need to add
> > this pinmux?
>
> I'm working on a board that is wired that way. I can of course put this
> in the board-specific dts if that's preferable.
So the board isn't submitted to mainline?
IMHO the change is okay, but the description doesn't explain why is it needed.
So a suitable description would be that it's needed for board xy.
>
> --
> M?ns Rullg?rd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:38 ` Stefan Wahren
@ 2016-01-10 13:42 ` Måns Rullgård
2016-01-10 13:58 ` Stefan Wahren
2016-01-10 19:01 ` Uwe Kleine-König
1 sibling, 1 reply; 8+ messages in thread
From: Måns Rullgård @ 2016-01-10 13:42 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
>> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> > Hi Mans,
>> >
>> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>> >>
>> >>
>> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >
>> > could you please change your patch to describe why you need to add
>> > this pinmux?
>>
>> I'm working on a board that is wired that way. I can of course put this
>> in the board-specific dts if that's preferable.
>
> So the board isn't submitted to mainline?
Not yet anyway.
> IMHO the change is okay, but the description doesn't explain why is it needed.
>
> So a suitable description would be that it's needed for board xy.
Would it be better to send this patch in a series along with the full
board support?
--
M?ns Rullg?rd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:42 ` Måns Rullgård
@ 2016-01-10 13:58 ` Stefan Wahren
2016-01-10 14:00 ` Måns Rullgård
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Wahren @ 2016-01-10 13:58 UTC (permalink / raw)
To: linux-arm-kernel
> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
> >> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> >>
> >>
> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
> >>
> >> > Hi Mans,
> >> >
> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
> >> >> geschrieben:
> >> >>
> >> >>
> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >> >
> >> > could you please change your patch to describe why you need to add
> >> > this pinmux?
> >>
> >> I'm working on a board that is wired that way. I can of course put this
> >> in the board-specific dts if that's preferable.
> >
> > So the board isn't submitted to mainline?
>
> Not yet anyway.
>
> > IMHO the change is okay, but the description doesn't explain why is it
> > needed.
> >
> > So a suitable description would be that it's needed for board xy.
>
> Would it be better to send this patch in a series along with the full
> board support?
>
Yes, it would be nice to have a dts file which reference the new pinmux.
> --
> M?ns Rullg?rd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:58 ` Stefan Wahren
@ 2016-01-10 14:00 ` Måns Rullgård
0 siblings, 0 replies; 8+ messages in thread
From: Måns Rullgård @ 2016-01-10 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
>> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> >> M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>> >>
>> >>
>> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> >>
>> >> > Hi Mans,
>> >> >
>> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
>> >> >> geschrieben:
>> >> >>
>> >> >>
>> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >> >
>> >> > could you please change your patch to describe why you need to add
>> >> > this pinmux?
>> >>
>> >> I'm working on a board that is wired that way. I can of course put this
>> >> in the board-specific dts if that's preferable.
>> >
>> > So the board isn't submitted to mainline?
>>
>> Not yet anyway.
>>
>> > IMHO the change is okay, but the description doesn't explain why is it
>> > needed.
>> >
>> > So a suitable description would be that it's needed for board xy.
>>
>> Would it be better to send this patch in a series along with the full
>> board support?
>>
>
> Yes, it would be nice to have a dts file which reference the new pinmux.
OK, I'll sit on it for a while longer then.
--
M?ns Rullg?rd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
2016-01-10 13:38 ` Stefan Wahren
2016-01-10 13:42 ` Måns Rullgård
@ 2016-01-10 19:01 ` Uwe Kleine-König
1 sibling, 0 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2016-01-10 19:01 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote:
> > M?ns Rullg?rd <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> > Stefan Wahren <stefan.wahren@i2se.com> writes:
> >
> > > Hi Mans,
> > >
> > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> > >>
> > >>
> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> > >
> > > could you please change your patch to describe why you need to add
> > > this pinmux?
> >
> > I'm working on a board that is wired that way. I can of course put this
> > in the board-specific dts if that's preferable.
>
> So the board isn't submitted to mainline?
>
> IMHO the change is okay, but the description doesn't explain why is it needed.
>
> So a suitable description would be that it's needed for board xy.
The problem with pinmuxing on i.MX23/28 is that the order of pinmux
groups is to a certain degree important. So not everything is possible
in the machine specific dts. (I didn't have an eye on this issue, maybe
it's fixed in the meantime?)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-10 19:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-10 12:40 [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Mans Rullgard
2016-01-10 13:08 ` Stefan Wahren
2016-01-10 13:13 ` Måns Rullgård
2016-01-10 13:38 ` Stefan Wahren
2016-01-10 13:42 ` Måns Rullgård
2016-01-10 13:58 ` Stefan Wahren
2016-01-10 14:00 ` Måns Rullgård
2016-01-10 19:01 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).