From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain'
Date: Mon, 11 Jan 2016 12:48:19 -0800 [thread overview]
Message-ID: <20160111204819.GA10522@roeck-us.net> (raw)
In-Reply-To: <CAOMZO5CkfXcZV3LTOP0oT__012ena9kmTYLb83dY9+BMj5X3hw@mail.gmail.com>
On Mon, Jan 11, 2016 at 06:14:31PM -0200, Fabio Estevam wrote:
> [Adding Rafael]
>
> On Mon, Jan 11, 2016 at 4:55 PM, Tony Lindgren <tony@atomide.com> wrote:
>
> >> I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points
> >> to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain").
> >> Failures are silent - there is no output on the console.
> >> Affected tests are
> >>
> >> arm:beagle:multi_v7_defconfig:omap3-beagle
> >> arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm
> >> arm:overo:multi_v7_defconfig:omap3-overo-tobi
> >> arm:beagle:omap2plus_defconfig:omap3-beagle
> >> arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm
> >> arm:overo:omap2plus_defconfig:omap3-overo-tobi
> >>
> >> For details please see the 'next' column at http://server.roeck-us.net:8010/builders.
> >>
> >> Reverting the offending commit fixes the problems.
> >>
> >> Please let me know if there is anything I can do to help tracking down the problem.
> >
> > The following fixes the booting, but I wonder if it's a
> > proper fix?
> >
> > --- a/drivers/base/power/common.c
> > +++ b/drivers/base/power/common.c
> > @@ -145,9 +145,10 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd)
> > {
> > if (dev->pm_domain == pd)
> > return;
> > -
> > - WARN(device_is_bound(dev),
> > - "PM domains can only be changed for unbound devices\n");
> > + if (device_is_registered(dev)) {
> > + WARN(device_is_bound(dev),
> > + "PM domains can only be changed for unbound devices\n");
> > + }
> > dev->pm_domain = pd;
> > device_pm_check_callbacks(dev);
>
> Commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain")
> causes issues for me after doing a 'reboot' command.
>
> Rafael proposed a patch which fixed the 'reboot' problem:
> http://www.spinics.net/lists/arm-kernel/msg473562.html
Looks like a different problem.
Guenter
next prev parent reply other threads:[~2016-01-11 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 17:51 arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' Guenter Roeck
2016-01-11 18:55 ` Tony Lindgren
2016-01-11 20:04 ` Guenter Roeck
2016-01-11 22:49 ` Rafael J. Wysocki
2016-01-11 23:39 ` Guenter Roeck
2016-01-12 0:15 ` Tony Lindgren
2016-01-12 0:24 ` Rafael J. Wysocki
2016-01-11 20:14 ` Fabio Estevam
2016-01-11 20:48 ` Guenter Roeck [this message]
2016-01-11 22:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111204819.GA10522@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).