From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] net: bpf: reject invalid shifts
Date: Tue, 12 Jan 2016 15:56:09 -0500 (EST) [thread overview]
Message-ID: <20160112.155609.526505451119578505.davem@davemloft.net> (raw)
In-Reply-To: <1452626228-15742-1-git-send-email-rabin@rab.in>
From: Rabin Vincent <rabin@rab.in>
Date: Tue, 12 Jan 2016 20:17:08 +0100
> On ARM64, a BUG() is triggered in the eBPF JIT if a filter with a
> constant shift that can't be encoded in the immediate field of the
> UBFM/SBFM instructions is passed to the JIT. Since these shifts
> amounts, which are negative or >= regsize, are invalid, reject them in
> the eBPF verifier and the classic BPF filter checker, for all
> architectures.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
> v2: handle BPF_ARSH too
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-01-12 20:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 17:55 [PATCH] net: bpf: reject invalid shifts Rabin Vincent
2016-01-12 18:51 ` Alexei Starovoitov
2016-01-12 19:17 ` [PATCHv2] " Rabin Vincent
2016-01-12 19:26 ` Alexei Starovoitov
2016-01-12 19:35 ` Daniel Borkmann
2016-01-12 19:48 ` Eric Dumazet
2016-01-12 19:53 ` Alexei Starovoitov
2016-01-12 20:42 ` Daniel Borkmann
2016-01-12 20:46 ` Alexei Starovoitov
2016-01-12 23:28 ` Eric Dumazet
2016-01-12 23:47 ` Alexei Starovoitov
2016-01-12 23:59 ` Hannes Frederic Sowa
2016-01-13 0:17 ` Hannes Frederic Sowa
2016-01-13 0:19 ` Alexei Starovoitov
2016-01-13 0:42 ` Hannes Frederic Sowa
2016-01-13 2:11 ` Eric Dumazet
2016-01-13 2:24 ` Alexei Starovoitov
2016-01-13 2:45 ` David Miller
2016-01-13 2:43 ` David Miller
2016-01-13 4:07 ` Eric Dumazet
2016-01-13 5:00 ` David Miller
2016-01-13 4:27 ` Hannes Frederic Sowa
2016-01-12 22:34 ` Eric Dumazet
2016-01-12 20:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112.155609.526505451119578505.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).