From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl
Date: Tue, 12 Jan 2016 07:41:07 +0000 [thread overview]
Message-ID: <20160112074107.GK19803@x1> (raw)
In-Reply-To: <5694584D.7040301@huawei.com>
On Tue, 12 Jan 2016, xuejiancheng wrote:
>
>
> On 2016/1/11 16:55, Lee Jones wrote:
> > On Mon, 11 Jan 2016, xuejiancheng wrote:
> >> On 2016/1/11 13:48, Lee Jones wrote:
> >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> >>>
> >>>> Add device tree bindings for Hi3519 system controller.
> >>>>
> >>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> >>>> 1 file changed, 14 insertions(+)
> >>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>
> >>> I have this patch, but none of the others in the set, thus I am
> >>> lacking context.
> >>>
> >> I can forward other patches in the set to you. Thank you.
> >>
> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> new file mode 100644
> >>>> index 0000000..115c5be
> >>>> --- /dev/null
> >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> @@ -0,0 +1,14 @@
> >>>> +* Hisilicon Hi3519 System Controller Block
> >>>> +
> >>>> +This bindings use the following binding:
> >>>> +Documentation/devicetree/bindings/mfd/syscon.txt
> >>>> +
> >>>> +Required properties:
> >>>> +- compatible: "hisilicon,hi3519-sysctrl".
> >>>> +- reg: the register region of this block
> >>>> +
> >>>> +Examples:
> >>>> +sysctrl: system-controller at 12010000 {
> >>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >>>> + reg = <0x12010000 0x1000>;
> >>>> +};
> >>>
> >>> There is no requirement (nor want) for binding documents where the
> >>> given device is simply using highly generic bindings. This just
> >>> amounts to churn.
> >>>
> >> This block is specific for Hi3519 SOC, and may has its own driver.
> >
> > Does it have its own driver currently?
> >
> Not yet.
> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
> with the SOC name. This binding is just used for describing the compatible string now.
> When more functions on hi3519 SOC are added later, the specific driver will be also
> needed.
Save this binding until it has more functionality. We here "I'll add
to this later" all too often.
> >> So I think it's better to keep this binding.
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-01-12 7:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:16 [PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 1/6] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2016-01-09 6:24 ` kbuild test robot
2016-01-09 15:33 ` Rob Herring
2016-01-11 3:47 ` xuejiancheng
2016-01-12 22:12 ` Stephen Boyd
2016-01-13 3:03 ` xuejiancheng
2016-01-13 18:57 ` Michael Turquette
2016-01-14 13:16 ` xuejiancheng
2016-01-15 7:57 ` xuejiancheng
2016-01-19 18:20 ` Rob Herring
2016-01-20 6:38 ` Tomeu Vizoso
2016-01-22 8:50 ` xuejiancheng
2016-01-22 9:55 ` Tomeu Vizoso
2016-01-08 2:16 ` [PATCH v5 2/6] ARM: hisi: add compatible string for Hi3519 soc Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue
2016-01-08 15:08 ` Russell King - ARM Linux
2016-01-11 2:32 ` xuejiancheng
2016-01-08 2:16 ` [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2016-01-08 21:04 ` Rob Herring
2016-01-11 5:48 ` Lee Jones
2016-01-11 7:50 ` xuejiancheng
2016-01-11 8:55 ` Lee Jones
2016-01-12 1:35 ` xuejiancheng
2016-01-12 7:41 ` Lee Jones [this message]
2016-01-12 8:17 ` xuejiancheng
2016-01-12 8:39 ` Lee Jones
2016-01-12 9:28 ` xuejiancheng
2016-01-12 22:51 ` Arnd Bergmann
2016-01-13 9:08 ` xuejiancheng
2016-01-13 10:00 ` Arnd Bergmann
2016-01-25 14:26 ` Lee Jones
2016-01-25 14:45 ` Arnd Bergmann
2016-01-08 2:16 ` [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue
2016-01-08 15:10 ` Russell King - ARM Linux
2016-01-11 2:05 ` xuejiancheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112074107.GK19803@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).