* [PATCH] mfd: asic3: remove extraneous ')'
@ 2016-01-12 9:02 Arnd Bergmann
2016-01-12 9:16 ` Lee Jones
2016-01-14 9:09 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-01-12 9:02 UTC (permalink / raw)
To: linux-arm-kernel
A cleanup patch introduced an extra closing ')' that leads to a
build error:
drivers/mfd/asic3.c: In function 'asic3_gpio_get':
drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
This removes the extra character to get it to build again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
---
This came up today on linux-next. I took the liberty to adjust formatting
of that line as well, if you prefer the original line wrapping please
undo that part when applying.
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index c8d46e51faf1..4dca6bc61f5b 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
return -EINVAL;
}
- return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
- & mask));
+ return !!(asic3_read_register(asic,
+ gpio_base + ASIC3_GPIO_STATUS) & mask);
}
static void asic3_gpio_set(struct gpio_chip *chip,
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] mfd: asic3: remove extraneous ')'
2016-01-12 9:02 [PATCH] mfd: asic3: remove extraneous ')' Arnd Bergmann
@ 2016-01-12 9:16 ` Lee Jones
2016-01-12 9:16 ` Lee Jones
2016-01-14 9:09 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2016-01-12 9:16 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 12 Jan 2016, Arnd Bergmann wrote:
> A cleanup patch introduced an extra closing ')' that leads to a
> build error:
>
> drivers/mfd/asic3.c: In function 'asic3_gpio_get':
> drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
>
> This removes the extra character to get it to build again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
> ---
> This came up today on linux-next. I took the liberty to adjust formatting
> of that line as well, if you prefer the original line wrapping please
> undo that part when applying.
Please ignore MFD in next, as it's not quite ready. I've been on
vacation for 4 weeks and only returned to work yesterday. I am
currently running MFD through AIAIAI and will fix-up any issues I
find.
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index c8d46e51faf1..4dca6bc61f5b 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> return -EINVAL;
> }
>
> - return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> - & mask));
> + return !!(asic3_read_register(asic,
> + gpio_base + ASIC3_GPIO_STATUS) & mask);
> }
>
> static void asic3_gpio_set(struct gpio_chip *chip,
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] mfd: asic3: remove extraneous ')'
2016-01-12 9:16 ` Lee Jones
@ 2016-01-12 9:16 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2016-01-12 9:16 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 12 Jan 2016, Lee Jones wrote:
> On Tue, 12 Jan 2016, Arnd Bergmann wrote:
> > A cleanup patch introduced an extra closing ')' that leads to a
> > build error:
> >
> > drivers/mfd/asic3.c: In function 'asic3_gpio_get':
> > drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
> >
> > This removes the extra character to get it to build again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
> > ---
> > This came up today on linux-next. I took the liberty to adjust formatting
> > of that line as well, if you prefer the original line wrapping please
> > undo that part when applying.
>
> Please ignore MFD in next, as it's not quite ready. I've been on
> vacation for 4 weeks and only returned to work yesterday. I am
> currently running MFD through AIAIAI and will fix-up any issues I
> find.
As for you Linus. Tut tut. ;)
> > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> > index c8d46e51faf1..4dca6bc61f5b 100644
> > --- a/drivers/mfd/asic3.c
> > +++ b/drivers/mfd/asic3.c
> > @@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> > return -EINVAL;
> > }
> >
> > - return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> > - & mask));
> > + return !!(asic3_read_register(asic,
> > + gpio_base + ASIC3_GPIO_STATUS) & mask);
> > }
> >
> > static void asic3_gpio_set(struct gpio_chip *chip,
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mfd: asic3: remove extraneous ')'
2016-01-12 9:02 [PATCH] mfd: asic3: remove extraneous ')' Arnd Bergmann
2016-01-12 9:16 ` Lee Jones
@ 2016-01-14 9:09 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-01-14 9:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 12, 2016 at 10:02 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> A cleanup patch introduced an extra closing ')' that leads to a
> build error:
>
> drivers/mfd/asic3.c: In function 'asic3_gpio_get':
> drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
>
> This removes the extra character to get it to build again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
> ---
> This came up today on linux-next. I took the liberty to adjust formatting
> of that line as well, if you prefer the original line wrapping please
> undo that part when applying.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Sorry for the mess, apparently one of those I didn't find a good
way of building...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-14 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-12 9:02 [PATCH] mfd: asic3: remove extraneous ')' Arnd Bergmann
2016-01-12 9:16 ` Lee Jones
2016-01-12 9:16 ` Lee Jones
2016-01-14 9:09 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).