From mboxrd@z Thu Jan 1 00:00:00 1970 From: sre@kernel.org (Sebastian Reichel) Date: Thu, 14 Jan 2016 13:07:06 +0100 Subject: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS In-Reply-To: <1452762920-2588-1-git-send-email-kishon@ti.com> References: <1452762920-2588-1-git-send-email-kishon@ti.com> Message-ID: <20160114120706.GA12774@earth> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, Jan 14, 2016 at 02:45:20PM +0530, Kishon Vijay Abraham I wrote: > Since v4.3+, CONFIG_REGULATOR_PBIAS should be enabled (for platforms that > have PBIAS regulator) in order for MMC1 to work. > > Add a more verbose print to help enable CONFIG_REGULATOR_PBIAS for users > using a olddefconfig or a custom .config. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/mmc/host/omap_hsmmc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 7fb0753..7086bd6 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -503,8 +503,11 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > host->pbias = devm_regulator_get_optional(host->dev, "pbias"); > if (IS_ERR(host->pbias)) { > ret = PTR_ERR(host->pbias); > - if ((ret != -ENODEV) && host->dev->of_node) > + if ((ret != -ENODEV) && host->dev->of_node) { > + dev_err(host->dev, > + "SD card detect fail? enable CONFIG_REGULATOR_PBIAS\n"); > return ret; > + } > dev_dbg(host->dev, "unable to get pbias regulator %ld\n", > PTR_ERR(host->pbias)); > host->pbias = NULL; Is there a good reason against adding "depends on REGULATOR_PBIAS" to MMC_OMAP_HS? I guess it's required for most systems and the regulator driver is just 250 loc. I am aware, that this will disable the hsmmc driver for 'make oldconfig', but I guess that will be noticed in a similar way your warning is noticed. The advantage of having the depends line is, that people configuring their kernel have a chance to notice the regulator requirement during configuration. Anyways, this message improves the situation, so: Acked-By: Sebastian Reichel -- Sebastian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: