From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD
Date: Fri, 15 Jan 2016 12:31:30 -0600 [thread overview]
Message-ID: <20160115183130.GB5296@localhost> (raw)
In-Reply-To: <56973DEC.2000108@ti.com>
On Thu, Jan 14, 2016 at 11:49:24AM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 14 January 2016 12:18 AM, Grygorii Strashko wrote:
> > On 01/13/2016 07:50 PM, Bjorn Helgaas wrote:
> >> On Wed, Jan 13, 2016 at 02:39:04PM +0100, Sebastian Andrzej Siewior wrote:
> >>> * Bjorn Helgaas | 2016-01-06 16:18:27 [-0600]:
> >>>
> >>>> Hi Bjorn,
> >>>
> >>>>> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> >>>>> index 8c36880..0415192 100644
> >>>>> --- a/drivers/pci/host/pci-dra7xx.c
> >>>>> +++ b/drivers/pci/host/pci-dra7xx.c
> >>>>> @@ -301,8 +301,19 @@ static int __init dra7xx_add_pcie_port(struct
> >>>>> dra7xx_pcie *dra7xx,
> >>>>> return -EINVAL;
> >>>>> }
> >>>>>
> >>>>> + /*
> >>>>> + * Mark dra7xx_pcie_msi IRQ as IRQF_NO_THREAD
> >>>>> + * On -RT and if kernel is booting with "threadirqs" cmd line parameter
> >>>>> + * the dra7xx_pcie_msi_irq_handler() will be forced threaded but,
> >>>>> + * in the same time, it's IRQ dispatcher and calls generic_handle_irq(),
> >>>>> + * which, in turn, will be resolved to handle_simple_irq() call.
> >>>>> + * The handle_simple_irq() expected to be called with IRQ disabled, as
> >>>>> + * result kernle will display warning:
> >>>>> + * "irq XXX handler YYY+0x0/0x14 enabled interrupts".
> >>>>> + */
> >>>
> >>> could you _please_ remove this coment? This kind of comment (if at all)
> >>> should be part of the commit message (which is the case more or less).
> >>
> >> IIRC, Grygorii specifically wanted to keep this comment in dra7xx, but
> >
> > True.
> >
> >> I do agree that this level of detail is more appropriate for a changelog.
> >>
> >> If Grygorii and Kishon don't object, I can update the patch to remove it.
> >
> > But no objections from my side. Thanks a lot.
>
> I don't have any objections.
OK, I dropped it, thanks guys!
Bjorn
next prev parent reply other threads:[~2016-01-15 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 19:18 [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD Grygorii Strashko
2016-01-06 22:18 ` Bjorn Helgaas
2016-01-13 13:39 ` Sebastian Andrzej Siewior
2016-01-13 17:50 ` Bjorn Helgaas
2016-01-13 18:48 ` Grygorii Strashko
2016-01-14 6:19 ` Kishon Vijay Abraham I
2016-01-15 18:31 ` Bjorn Helgaas [this message]
2016-01-07 9:18 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115183130.GB5296@localhost \
--to=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).