From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: xgene: Add SoC and PMD PLL clocks with v2 hardware
Date: Fri, 15 Jan 2016 15:46:47 -0800 [thread overview]
Message-ID: <20160115234647.GT22188@codeaurora.org> (raw)
In-Reply-To: <1450316255-9372-1-git-send-email-lho@apm.com>
On 12/16, Loc Ho wrote:
> @@ -41,6 +44,14 @@
>
> static DEFINE_SPINLOCK(clk_lock);
>
> +static int xgene_clk_version(void)
> +{
> + #define MIDR_EL1_VARIANT_MASK 0x00f00000
> + u32 val = read_cpuid_id();
> +
> + return (val & MIDR_EL1_VARIANT_MASK) == 0 ? 1 : 2;
> +}
This is very odd. It means that this file can't be test compiled
on non-arm64 platforms. It would be better to express the v1 vs.
v2 difference through DT compatible strings so that the driver
doesn't rely on reading the midr.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-01-15 23:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 1:37 [PATCH] clk: xgene: Add SoC and PMD PLL clocks with v2 hardware Loc Ho
2016-01-15 21:41 ` Loc Ho
2016-01-15 23:46 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115234647.GT22188@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).