From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/1] USB: core: let USB device know device node
Date: Mon, 18 Jan 2016 15:13:09 +0800 [thread overview]
Message-ID: <20160118071309.GC8150@shlinux2> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1601151220020.1533-100000@iolanthe.rowland.org>
On Fri, Jan 15, 2016 at 12:30:41PM -0500, Alan Stern wrote:
> On Fri, 15 Jan 2016, Philipp Zabel wrote:
>
> > > +- reg: the port number which this device is connecting to.
> >
> > Should it be noted here that the port number range is 1-255?
>
> Actually the range is 1 - 31 (defined by USB_MAXCHILDREN set in
> include/uapi/linux/usb/ch11.h).
>
> > > @@ -502,11 +503,14 @@ struct usb_device *usb_alloc_dev(struct usb_device *parent,
> > > dev->connect_time = jiffies;
> > > dev->active_duration = -jiffies;
> > > #endif
> > > - if (root_hub) /* Root hub always ok [and always wired] */
> > > + if (root_hub) { /* Root hub always ok [and always wired] */
> > > dev->authorized = 1;
> > > - else {
> > > + dev->of_node = bus->controller->of_node;
> >
> > Why can't the root_hub reuse dev->dev.of_node?
>
> Indeed, there's no need to add an .of_node field to struct usb_device,
> since the embedded struct device already contains an .of_node field.
>
No, the usb_device needs the .of_node field.
The devices belong to platform bus contains device node.
The devices (usb device) belong to USB bus which are created
dynamically do not contain device node.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-01-18 7:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:17 [PATCH v3 1/1] USB: core: let USB device know device node Peter Chen
2016-01-15 11:11 ` Arnd Bergmann
2016-01-15 15:11 ` Alan Stern
2016-01-15 23:03 ` Arnd Bergmann
2016-01-16 16:40 ` Alan Stern
2016-01-18 8:15 ` Peter Chen
2016-01-18 16:46 ` Alan Stern
2016-01-19 3:08 ` Peter Chen
2016-01-19 11:33 ` Arnd Bergmann
2016-01-19 15:12 ` Alan Stern
2016-01-20 3:48 ` Peter Chen
2016-01-20 9:07 ` Arnd Bergmann
2016-01-20 12:50 ` Peter Chen
2016-01-20 14:19 ` Arnd Bergmann
2016-01-21 3:15 ` Peter Chen
2016-01-21 8:41 ` Arnd Bergmann
2016-01-21 9:48 ` Peter Chen
2016-01-21 10:10 ` Arnd Bergmann
2016-01-21 15:21 ` Alan Stern
2016-01-21 22:24 ` Arnd Bergmann
2016-01-22 6:59 ` Peter Chen
2016-01-22 10:18 ` Arnd Bergmann
2016-01-22 15:55 ` Alan Stern
2016-01-22 16:23 ` Arnd Bergmann
2016-01-22 19:29 ` Alan Stern
2016-01-25 1:55 ` Peter Chen
2016-01-25 3:57 ` Peter Chen
2016-01-25 8:50 ` Arnd Bergmann
2016-01-25 9:31 ` Peter Chen
2016-01-25 15:23 ` Alan Stern
2016-01-18 10:24 ` Arnd Bergmann
2016-01-18 7:44 ` Peter Chen
2016-01-18 7:42 ` Peter Chen
2016-01-15 17:07 ` Philipp Zabel
2016-01-15 17:30 ` Alan Stern
2016-01-18 7:13 ` Peter Chen [this message]
2016-01-18 16:39 ` Alan Stern
2016-01-19 2:52 ` Peter Chen
2016-01-18 7:10 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118071309.GC8150@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).