* [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on, off} on exynos7
@ 2016-01-19 10:21 Alim Akhtar
2016-01-19 10:32 ` [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} " Mark Rutland
0 siblings, 1 reply; 3+ messages in thread
From: Alim Akhtar @ 2016-01-19 10:21 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds cpu-{on,off} function IDs as per PSCI specification,
with this we can boot multiple CPUs and can use cpu hotplug on
exynos7 platform.
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index f9c5a549c2c0..1a2bb3b453e5 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -65,6 +65,8 @@
psci {
compatible = "arm,psci-0.2";
method = "smc";
+ cpu_on = <0xC4000003>;
+ cpu_off = <0x84000002>;
};
soc: soc {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} on exynos7
2016-01-19 10:21 [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on, off} on exynos7 Alim Akhtar
@ 2016-01-19 10:32 ` Mark Rutland
2016-01-20 2:52 ` Alim Akhtar
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2016-01-19 10:32 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 19, 2016 at 03:51:24PM +0530, Alim Akhtar wrote:
> This patch adds cpu-{on,off} function IDs as per PSCI specification,
> with this we can boot multiple CPUs and can use cpu hotplug on
> exynos7 platform.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index f9c5a549c2c0..1a2bb3b453e5 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -65,6 +65,8 @@
> psci {
> compatible = "arm,psci-0.2";
> method = "smc";
> + cpu_on = <0xC4000003>;
> + cpu_off = <0x84000002>;
> };
There is no need for this patch.
The "arm,psci-0.2" compatible string implicitly tells the kernel that
the full set of mandatory PSCI 0.2 functions are present, with the IDs
mandated by PSCI 0.2. That includes CPU_ON and CPU_OFF amongst others.
The only reason to provide IDs is to function on kernels without PSCI
0.2 support. Given the compatible string hasn't been updated for that,
this is insufficient for that case.
Thanks,
Mark.
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} on exynos7
2016-01-19 10:32 ` [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} " Mark Rutland
@ 2016-01-20 2:52 ` Alim Akhtar
0 siblings, 0 replies; 3+ messages in thread
From: Alim Akhtar @ 2016-01-20 2:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
On 01/19/2016 04:02 PM, Mark Rutland wrote:
> On Tue, Jan 19, 2016 at 03:51:24PM +0530, Alim Akhtar wrote:
>> This patch adds cpu-{on,off} function IDs as per PSCI specification,
>> with this we can boot multiple CPUs and can use cpu hotplug on
>> exynos7 platform.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> index f9c5a549c2c0..1a2bb3b453e5 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> @@ -65,6 +65,8 @@
>> psci {
>> compatible = "arm,psci-0.2";
>> method = "smc";
>> + cpu_on = <0xC4000003>;
>> + cpu_off = <0x84000002>;
>> };
>
> There is no need for this patch.
>
> The "arm,psci-0.2" compatible string implicitly tells the kernel that
> the full set of mandatory PSCI 0.2 functions are present, with the IDs
> mandated by PSCI 0.2. That includes CPU_ON and CPU_OFF amongst others.
>
> The only reason to provide IDs is to function on kernels without PSCI
> 0.2 support. Given the compatible string hasn't been updated for that,
> this is insufficient for that case.
>
Ah, right, this patch is not required for psci,0.2, thanks for
clarification.
sorry for the noise.
> Thanks,
> Mark.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-20 2:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-19 10:21 [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on, off} on exynos7 Alim Akhtar
2016-01-19 10:32 ` [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} " Mark Rutland
2016-01-20 2:52 ` Alim Akhtar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).