linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: pwrseq_simple: Make reset-gpios optional to match doc
Date: Tue, 19 Jan 2016 18:34:34 -0800	[thread overview]
Message-ID: <20160120023433.GG19432@atomide.com> (raw)
In-Reply-To: <CABxcv=mYRG0rikgtY-fPj_BFhY8hgn_LYjcxEeY14rZD-BHpfg@mail.gmail.com>

Hi,

* Javier Martinez Canillas <javier@dowhile0.org> [160108 08:42]:
> On Fri, Jan 8, 2016 at 6:07 AM, Martin Fuzzey <mfuzzey@parkeon.com> wrote:
> > The DT binding doc says reset-gpios is an optional property but the code
> > currently bails out if it is omitted.
> >
> > Make the code match the documentation.
...
> Tony already posted a fix for this before [0] but got some feedback so
> is likely to post a v2 soon.

Hmm I think my patch would end up looking pretty much like Martin's
patch after fixing the comments. Based on what I understood, Ulf
wants to keep pwrseq_simple, well, simple as discussed in [0].

It also seems Ulf also wants to leave out the allocation, and does
want to add any deeper knowledge of the state of the GPIOs in
pwrse-simple. Instead, we can do device specific pwrseq for things
like Marvell 8787 and so on.

Ulf may have more comments, but $subject patch fixes the issue
I'm seeing with wl12xx on omap5 devices:

Tested-by: Tony Lindgren <tony@atomide.com>

Probably should be tagged Cc: stable # v4.4 when applied.

Regards,

Tony

> [0]: http://www.spinics.net/lists/linux-mmc/msg34398.html

  reply	other threads:[~2016-01-20  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08  9:07 [PATCH] mmc: pwrseq_simple: Make reset-gpios optional to match doc Martin Fuzzey
2016-01-08 16:42 ` Javier Martinez Canillas
2016-01-20  2:34   ` Tony Lindgren [this message]
2016-01-20 11:36 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120023433.GG19432@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).