* [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
@ 2016-01-20 9:53 Dan Carpenter
2016-01-20 23:14 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-01-20 9:53 UTC (permalink / raw)
To: linux-arm-kernel
"bpp" needs to be signed for the error handling to work.
Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index 7bfe243..c35e5af 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi)
static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
{
- unsigned int bpp, i, pre;
+ int bpp;
+ unsigned int i, pre;
unsigned long mpclk, pllref, tmp;
unsigned int m = 1, n = 1, target_mbps = 1000;
unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) - 1].max_mbps;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
2016-01-20 9:53 [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Dan Carpenter
@ 2016-01-20 23:14 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2016-01-20 23:14 UTC (permalink / raw)
To: linux-arm-kernel
Hi Dan,
Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter:
> "bpp" needs to be signed for the error handling to work.
>
> Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp
result" from Andrzej Hajda from january the 14th doing the same change.
Heiko
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi
> *dsi)
>
> static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
> {
> - unsigned int bpp, i, pre;
> + int bpp;
> + unsigned int i, pre;
> unsigned long mpclk, pllref, tmp;
> unsigned int m = 1, n = 1, target_mbps = 1000;
> unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) -
1].max_mbps;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-20 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 9:53 [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Dan Carpenter
2016-01-20 23:14 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).