* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
@ 2015-12-25 23:32 Pali Rohár
2015-12-26 18:50 ` Pavel Machek
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Pali Rohár @ 2015-12-25 23:32 UTC (permalink / raw)
To: linux-arm-kernel
Driver for omap3 with documentation is there since v4.4-rc1.
Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
---
arch/arm/boot/dts/omap34xx.dtsi | 5 +++++
arch/arm/boot/dts/omap36xx.dtsi | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
index 4f6b2d5..c3f488f 100644
--- a/arch/arm/boot/dts/omap34xx.dtsi
+++ b/arch/arm/boot/dts/omap34xx.dtsi
@@ -54,6 +54,11 @@
#size-cells = <0>;
};
};
+
+ bandgap {
+ reg = <0x48002524 0x4>;
+ compatible = "ti,omap34xx-bandgap";
+ };
};
};
diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
index 86253de..00f98c1 100644
--- a/arch/arm/boot/dts/omap36xx.dtsi
+++ b/arch/arm/boot/dts/omap36xx.dtsi
@@ -86,6 +86,11 @@
#size-cells = <0>;
};
};
+
+ bandgap {
+ reg = <0x48002524 0x4>;
+ compatible = "ti,omap36xx-bandgap";
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2015-12-25 23:32 [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver Pali Rohár
@ 2015-12-26 18:50 ` Pavel Machek
2015-12-31 17:38 ` Eduardo Valentin
2016-01-21 9:47 ` Pali Rohár
2 siblings, 0 replies; 10+ messages in thread
From: Pavel Machek @ 2015-12-26 18:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sat 2015-12-26 00:32:25, Pali Roh?r wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
>
> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Pavel Machek <pavel@ucw.cz>
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2015-12-25 23:32 [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver Pali Rohár
2015-12-26 18:50 ` Pavel Machek
@ 2015-12-31 17:38 ` Eduardo Valentin
2016-01-05 11:30 ` Pali Rohár
2016-01-21 9:47 ` Pali Rohár
2 siblings, 1 reply; 10+ messages in thread
From: Eduardo Valentin @ 2015-12-31 17:38 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Sat, Dec 26, 2015 at 12:32:25AM +0100, Pali Roh?r wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
>
> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> ---
> arch/arm/boot/dts/omap34xx.dtsi | 5 +++++
> arch/arm/boot/dts/omap36xx.dtsi | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 4f6b2d5..c3f488f 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -54,6 +54,11 @@
> #size-cells = <0>;
> };
> };
> +
> + bandgap {
> + reg = <0x48002524 0x4>;
> + compatible = "ti,omap34xx-bandgap";
> + };
> };
> };
>
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 86253de..00f98c1 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -86,6 +86,11 @@
> #size-cells = <0>;
> };
> };
> +
> + bandgap {
> + reg = <0x48002524 0x4>;
> + compatible = "ti,omap36xx-bandgap";
Can you please already add on both cases
#thermal-sensor-cells = <0>;
?
This way we can already use them to define thermal zones. Of course,
that alone won't add the thermal zones. A separated patch would be
needed to add the thermal zone for OMAP3.
> + };
> };
> };
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2015-12-31 17:38 ` Eduardo Valentin
@ 2016-01-05 11:30 ` Pali Rohár
0 siblings, 0 replies; 10+ messages in thread
From: Pali Rohár @ 2016-01-05 11:30 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 31 December 2015 09:38:45 Eduardo Valentin wrote:
> > +
> > + bandgap {
> > + reg = <0x48002524 0x4>;
> > + compatible = "ti,omap36xx-bandgap";
>
> Can you please already add on both cases
>
> #thermal-sensor-cells = <0>;
> ?
>
> This way we can already use them to define thermal zones. Of course,
> that alone won't add the thermal zones. A separated patch would be
> needed to add the thermal zone for OMAP3.
Are you going to add thermal zone defines? If yes, then it would make
sense to add that #thermal line together with thermal zone defines...
--
Pali Roh?r
pali.rohar at gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2015-12-25 23:32 [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver Pali Rohár
2015-12-26 18:50 ` Pavel Machek
2015-12-31 17:38 ` Eduardo Valentin
@ 2016-01-21 9:47 ` Pali Rohár
2016-01-21 17:15 ` Tony Lindgren
2 siblings, 1 reply; 10+ messages in thread
From: Pali Rohár @ 2016-01-21 9:47 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
>
> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> ---
> arch/arm/boot/dts/omap34xx.dtsi | 5 +++++
> arch/arm/boot/dts/omap36xx.dtsi | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 4f6b2d5..c3f488f 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -54,6 +54,11 @@
> #size-cells = <0>;
> };
> };
> +
> + bandgap {
> + reg = <0x48002524 0x4>;
> + compatible = "ti,omap34xx-bandgap";
> + };
> };
> };
>
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 86253de..00f98c1 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -86,6 +86,11 @@
> #size-cells = <0>;
> };
> };
> +
> + bandgap {
> + reg = <0x48002524 0x4>;
> + compatible = "ti,omap36xx-bandgap";
> + };
> };
> };
>
PING! Who can take this patch?
--
Pali Roh?r
pali.rohar at gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2016-01-21 9:47 ` Pali Rohár
@ 2016-01-21 17:15 ` Tony Lindgren
2016-01-27 10:04 ` Pali Rohár
0 siblings, 1 reply; 10+ messages in thread
From: Tony Lindgren @ 2016-01-21 17:15 UTC (permalink / raw)
To: linux-arm-kernel
* Pali Roh?r <pali.rohar@gmail.com> [160121 01:48]:
> On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> > Driver for omap3 with documentation is there since v4.4-rc1.
...
> PING! Who can take this patch?
Sounds like /me, but after -rc1 when any possible regressions
are out of the way :)
Regards,
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2016-01-21 17:15 ` Tony Lindgren
@ 2016-01-27 10:04 ` Pali Rohár
2016-01-27 16:09 ` Tony Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Pali Rohár @ 2016-01-27 10:04 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> * Pali Roh?r <pali.rohar@gmail.com> [160121 01:48]:
> > On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> > > Driver for omap3 with documentation is there since v4.4-rc1.
> ...
>
> > PING! Who can take this patch?
>
> Sounds like /me, but after -rc1 when any possible regressions
> are out of the way :)
Great! Just to note that 4.5-rc1 is out.
I just do not want to see this patch lost...
--
Pali Roh?r
pali.rohar at gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2016-01-27 10:04 ` Pali Rohár
@ 2016-01-27 16:09 ` Tony Lindgren
2016-01-27 18:19 ` Sebastian Reichel
0 siblings, 1 reply; 10+ messages in thread
From: Tony Lindgren @ 2016-01-27 16:09 UTC (permalink / raw)
To: linux-arm-kernel
* Pali Roh?r <pali.rohar@gmail.com> [160127 02:05]:
> On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > * Pali Roh?r <pali.rohar@gmail.com> [160121 01:48]:
> > > On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > ...
> >
> > > PING! Who can take this patch?
> >
> > Sounds like /me, but after -rc1 when any possible regressions
> > are out of the way :)
>
> Great! Just to note that 4.5-rc1 is out.
>
> I just do not want to see this patch lost...
So is this critical to have as a fix since it's thermal related?
Regards,
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2016-01-27 16:09 ` Tony Lindgren
@ 2016-01-27 18:19 ` Sebastian Reichel
2016-01-27 18:24 ` Tony Lindgren
0 siblings, 1 reply; 10+ messages in thread
From: Sebastian Reichel @ 2016-01-27 18:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Jan 27, 2016 at 08:09:46AM -0800, Tony Lindgren wrote:
> * Pali Roh?r <pali.rohar@gmail.com> [160127 02:05]:
> > On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > > * Pali Roh?r <pali.rohar@gmail.com> [160121 01:48]:
> > > > On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> > > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > > ...
> > >
> > > > PING! Who can take this patch?
> > >
> > > Sounds like /me, but after -rc1 when any possible regressions
> > > are out of the way :)
> >
> > Great! Just to note that 4.5-rc1 is out.
> >
> > I just do not want to see this patch lost...
>
> So is this critical to have as a fix since it's thermal related?
According to somebody from TI, who previously took part in the patch
discussion, the thermal sensors of omap3 are to imprecise to be used
for thermal decisions. The driver "just" informs userspace about the
temperatures.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/9920a723/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver
2016-01-27 18:19 ` Sebastian Reichel
@ 2016-01-27 18:24 ` Tony Lindgren
0 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2016-01-27 18:24 UTC (permalink / raw)
To: linux-arm-kernel
* Sebastian Reichel <sre@kernel.org> [160127 10:20]:
> Hi,
>
> On Wed, Jan 27, 2016 at 08:09:46AM -0800, Tony Lindgren wrote:
> > * Pali Roh?r <pali.rohar@gmail.com> [160127 02:05]:
> > > On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > > > * Pali Roh?r <pali.rohar@gmail.com> [160121 01:48]:
> > > > > On Saturday 26 December 2015 00:32:25 Pali Roh?r wrote:
> > > > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > > > ...
> > > >
> > > > > PING! Who can take this patch?
> > > >
> > > > Sounds like /me, but after -rc1 when any possible regressions
> > > > are out of the way :)
> > >
> > > Great! Just to note that 4.5-rc1 is out.
> > >
> > > I just do not want to see this patch lost...
> >
> > So is this critical to have as a fix since it's thermal related?
>
> According to somebody from TI, who previously took part in the patch
> discussion, the thermal sensors of omap3 are to imprecise to be used
> for thermal decisions. The driver "just" informs userspace about the
> temperatures.
OK applying into omap-for-v4.6/dt then thanks.
Tony
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-01-27 18:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-25 23:32 [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver Pali Rohár
2015-12-26 18:50 ` Pavel Machek
2015-12-31 17:38 ` Eduardo Valentin
2016-01-05 11:30 ` Pali Rohár
2016-01-21 9:47 ` Pali Rohár
2016-01-21 17:15 ` Tony Lindgren
2016-01-27 10:04 ` Pali Rohár
2016-01-27 16:09 ` Tony Lindgren
2016-01-27 18:19 ` Sebastian Reichel
2016-01-27 18:24 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).