[RFC PATCH 4/5] PM / AVS: thermal: MT8173: Introduce support for SVS engine

Henry Chen
2016-02-19T05:31:25Z

On Fri, 2016-02-19 at 13:08 +0800, Henry Chen wrote:
> On Thu, 2016-02-18 at 11:00 +0800, Pi-Cheng Chen wrote:
>
> > > > + vboot = regulator_get_voltage(svs->reg) / 1000;
> > > > + if (mvolt_to_config(vboot) !=
> > > > + mvolt_to_config(svs_bank_cfgs[i].vboot)) {
> > > > + dev_err(svs->dev, "Vboot value mismatch!\n");
> > > > + ret = -EINVAL;
> > > > + break;
> > > > + }
> > > > +
> > > > + ret = regulator_set_mode(svs->reg, REGULATOR_MODE_FAST);
> > > > + if (ret) {
> > > > + dev_err(svs->dev,
> > > > + "Failed to set regulator in PWM mode\n");
> > > > + ret = -EINVAL;
> > > > + break;
> > > > + }
> > >
> > > Shouldn't this be best effort?
> > > If we can't set the regulator to fast mode, can we continue anyway?
> > >
> >
> > AFAIK, we need to set the regulator to fast mode to get stable voltage as
> > possible. I am sure about the details.
> >
> > @Henry,
> > Would you please comment it?
>

Hi,

Correct typos.Sorry for the wrong module name.

Yes, as you said, SVS need the more precisely voltage as possible when
driver initialize, there has two mode in mt6397: pwm/auto mode, the pwm
mode which can get the more stable Vout than auto mode.

Thanks,
Henry