linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: r8a7793: add CAN clocks
Date: Wed, 27 Jan 2016 18:25:43 +0900	[thread overview]
Message-ID: <20160127092536.GA24261@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXDrFFhsTQ_2arc4rq-NiX-pg_a60YbJZE352Tg856-yw@mail.gmail.com>

On Fri, Jan 22, 2016 at 08:46:37AM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 22, 2016 at 1:48 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > > --- a/arch/arm/boot/dts/r8a7793.dtsi
> >> > > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> >> > > @@ -706,12 +706,30 @@
> >> > >                         clock-output-names = "extal";
> >> > >                 };
> >> > >
> >> > > +               /* External USB clock - can be overridden by the board */
> >> > > +               usb_extal_clk: usb_extal_clk {
> >> > > +                       compatible = "fixed-clock";
> >> > > +                       #clock-cells = <0>;
> >> > > +                       clock-frequency = <48000000>;
> >> > > +                       clock-output-names = "usb_extal";
> >> > > +               };
> >> > > +
> >> > > +               /* External CAN clock */
> >> > > +               can_clk: can_clk {
> >> > > +                       compatible = "fixed-clock";
> >> > > +                       #clock-cells = <0>;
> >> > > +                       /* This value must be overridden by the board. */
> >> > > +                       clock-frequency = <0>;
> >> > > +                       clock-output-names = "can_clk";
> >> > > +                       status = "disabled";
> >> > > +               };
> >> > > +
> >> > >                 /* Special CPG clocks */
> >> > >                 cpg_clocks: cpg_clocks at e6150000 {
> >> > >                         compatible = "renesas,r8a7793-cpg-clocks",
> >> > >                                      "renesas,rcar-gen2-cpg-clocks";
> >> > >                         reg = <0 0xe6150000 0 0x1000>;
> >> > > -                       clocks = <&extal_clk>;
> >> > > +                       clocks = <&extal_clk &usb_extal_clk>;
> >> > >                         #clock-cells = <1>;
> >> > >                         clock-output-names = "main", "pll0", "pll1", "pll3",
> >> > >                                              "lb", "qspi", "sdh", "sd0", "z",
> >> >
> >> > To create the "rcan" clock, it should be listed in clock-output-names.
> >
> > Checking this morning I see that it is already there.
> > The next line of the file is:
> >
> >                                              "rcan", "adsp";
> 
> I stand corrected.
> 
> BTW, that means you saw "failed to register ... rcan" messages
> before?

Yes, I checked and I see:

rcar_gen2_cpg_clocks_init: failed to register cpg_clocks rcan clock (-12)

  reply	other threads:[~2016-01-27  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21  5:09 [PATCH 0/2] ARM: dts: r8a7793: add CAN to device tree Simon Horman
2016-01-21  5:09 ` [PATCH 1/2] ARM: dts: r8a7793: add CAN clocks Simon Horman
2016-01-21  8:38   ` Geert Uytterhoeven
2016-01-21 12:15     ` Simon Horman
2016-01-22  0:48       ` Simon Horman
2016-01-22  7:46         ` Geert Uytterhoeven
2016-01-27  9:25           ` Simon Horman [this message]
2016-01-21  5:09 ` [PATCH 2/2] ARM: dts: r8a7793: add CAN nodes to device tree Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160127092536.GA24261@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).