From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: tegra: Fixed typo
Date: Wed, 27 Jan 2016 15:10:26 +0100 [thread overview]
Message-ID: <20160127141026.GA21779@ulmo> (raw)
In-Reply-To: <56A88AC6.4090105@nvidia.com>
On Wed, Jan 27, 2016 at 06:15:50PM +0900, Alexandre Courbot wrote:
> On 01/27/16 17:45, Ralf Ramsauer wrote:
> >On 01/27/2016 08:59 AM, Alexandre Courbot wrote:
> >>Hey Ralf, thanks for following up with patches as we discussed in private!
> >>
> >>Small nit: you will want to use the active form ("Fix typo" instead of
> >>"Fixed typo") in your commit messages.
> >So even my language skills got improved ;-)
>
> This is grammatically correct, but using imperative form is the convention
> in the kernel. As per Documentation/SubmittingPatches:
>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
>
> >>It would also be nice if the commit title was a little more precise
> >>about where the typo has been corrected.
> >Uhm - as this is be pretty small non-diff-related change... Is it
> >necessary to send a v3 or would it also be okay to let the maintainer
> >amend the subject?
> >(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
>
> Let's see what Thierry says about this.
I've changed this when applying and also added a full commit message.
Doing so might arguably be a little overkill, but in doing so I realized
that the same typo was there in the Tegra132 and Tegra210 DTS includes,
so I fixed those up in a separate patch while at it. I made it a
separate patch because the arm-soc maintainers want arch/arm and
arch/arm64 changes to come in via separate branches. I did add a
Suggested-by for Ralf since he spotted the original typo, I hope that's
okay with everyone.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/24bc8ead/attachment-0001.sig>
next prev parent reply other threads:[~2016-01-27 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 16:59 [PATCH v2 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1 Ralf Ramsauer
2016-01-26 16:59 ` [PATCH v2 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
2016-01-27 7:59 ` Alexandre Courbot
2016-01-27 8:45 ` Ralf Ramsauer
2016-01-27 9:15 ` Alexandre Courbot
2016-01-27 14:10 ` Thierry Reding [this message]
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
2016-01-26 19:27 ` Stephen Warren
2016-01-26 19:35 ` Ralf Ramsauer
2016-01-27 14:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127141026.GA21779@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).