* [PATCH v2 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1
@ 2016-01-26 16:59 Ralf Ramsauer
2016-01-26 16:59 ` [PATCH v2 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
0 siblings, 2 replies; 10+ messages in thread
From: Ralf Ramsauer @ 2016-01-26 16:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi everyone,
this one enables the high speed UARTs of the Jetson TK1 (and corrects
a not noteworthy typo). Those additional UARTs are exposed on the
expansion connector of the TK1.
So far, they were only enabled in NVidia's official BSP.
Ralf
Ralf Ramsauer (2):
ARM: tegra: Fixed typo
ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
arch/arm/boot/dts/tegra114.dtsi | 2 +-
arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++
arch/arm/boot/dts/tegra124.dtsi | 2 +-
arch/arm/boot/dts/tegra20.dtsi | 2 +-
arch/arm/boot/dts/tegra30.dtsi | 2 +-
5 files changed, 30 insertions(+), 4 deletions(-)
--
2.4.10
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: tegra: Fixed typo
2016-01-26 16:59 [PATCH v2 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1 Ralf Ramsauer
@ 2016-01-26 16:59 ` Ralf Ramsauer
2016-01-27 7:59 ` Alexandre Courbot
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
1 sibling, 1 reply; 10+ messages in thread
From: Ralf Ramsauer @ 2016-01-26 16:59 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
---
arch/arm/boot/dts/tegra114.dtsi | 2 +-
arch/arm/boot/dts/tegra124.dtsi | 2 +-
arch/arm/boot/dts/tegra20.dtsi | 2 +-
arch/arm/boot/dts/tegra30.dtsi | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index d845bd1..5017ed8 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -256,7 +256,7 @@
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
- * the APB DMA based serial driver, the comptible is
+ * the APB DMA based serial driver, the compatible is
* "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
*/
uarta: serial at 70006000 {
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 68669f7..995289b 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -322,7 +322,7 @@
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
- * the APB DMA based serial driver, the comptible is
+ * the APB DMA based serial driver, the compatible is
* "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart".
*/
uarta: serial at 0,70006000 {
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 33173e1..8fb61b9 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -309,7 +309,7 @@
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra20-uart" and to enable the APB DMA based serial
- * driver, the comptible is "nvidia,tegra20-hsuart".
+ * driver, the compatible is "nvidia,tegra20-hsuart".
*/
uarta: serial at 70006000 {
compatible = "nvidia,tegra20-uart";
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index 313e260..c6edc8c 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -371,7 +371,7 @@
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable
- * the APB DMA based serial driver, the comptible is
+ * the APB DMA based serial driver, the compatible is
* "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart".
*/
uarta: serial at 70006000 {
--
2.4.10
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
2016-01-26 16:59 [PATCH v2 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1 Ralf Ramsauer
2016-01-26 16:59 ` [PATCH v2 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
@ 2016-01-26 16:59 ` Ralf Ramsauer
2016-01-26 19:27 ` Stephen Warren
2016-01-27 14:15 ` Thierry Reding
1 sibling, 2 replies; 10+ messages in thread
From: Ralf Ramsauer @ 2016-01-26 16:59 UTC (permalink / raw)
To: linux-arm-kernel
This patch enables the APB DMA high speed UARTs of the Jetson TK1. So
far, they were only enabled in NVidia's official BSP.
Those additional UARTs are exposed on the expansion connector J3A2:
UART1:
Pin 41: BR_UART1_TXD
Pin 44: BR_UART1_RXD
UART2:
Pin 65: UART2_RXD
Pin 68: UART2_TXD
Pin 71: UART2_CTS_L
Pin 74: UART2_RTS_L
Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
---
arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
index 66b4451..4ee2e63 100644
--- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts
+++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
@@ -12,7 +12,11 @@
aliases {
rtc0 = "/i2c at 0,7000d000/pmic at 40";
rtc1 = "/rtc at 0,7000e000";
+
+ /* This order keeps the mapping DB9 connector <-> ttyS0 */
serial0 = &uartd;
+ serial1 = &uarta;
+ serial2 = &uartb;
};
memory {
@@ -1367,6 +1371,28 @@
};
};
+ /*
+ * First high speed UART, exposed on the expansion connector J3A2
+ * Pin 41: BR_UART1_TXD
+ * Pin 44: BR_UART1_RXD
+ */
+ serial at 0,70006000 {
+ compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ status = "okay";
+ };
+
+ /*
+ * Second high speed UART, exposed on the expansion connector J3A2
+ * Pin 65: UART2_RXD
+ * Pin 68: UART2_TXD
+ * Pin 71: UART2_CTS_L
+ * Pin 74: UART2_RTS_L
+ */
+ serial at 0,70006040 {
+ compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ status = "okay";
+ };
+
/* DB9 serial port */
serial at 0,70006300 {
status = "okay";
--
2.4.10
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
@ 2016-01-26 19:27 ` Stephen Warren
2016-01-26 19:35 ` Ralf Ramsauer
2016-01-27 14:15 ` Thierry Reding
1 sibling, 1 reply; 10+ messages in thread
From: Stephen Warren @ 2016-01-26 19:27 UTC (permalink / raw)
To: linux-arm-kernel
On 01/26/2016 09:59 AM, Ralf Ramsauer wrote:
> This patch enables the APB DMA high speed UARTs of the Jetson TK1. So
> far, they were only enabled in NVidia's official BSP.
>
> Those additional UARTs are exposed on the expansion connector J3A2:
>
> UART1:
> Pin 41: BR_UART1_TXD
> Pin 44: BR_UART1_RXD
>
> UART2:
> Pin 65: UART2_RXD
> Pin 68: UART2_TXD
> Pin 71: UART2_CTS_L
> Pin 74: UART2_RTS_L
The series,
Acked-by: Stephen Warren <swarren@nvidia.com>
As an aside, this is perfectly OK, but I wonder why you chose to use
compatible=nvidia,tegra124-hsuart rather than
compatible=nvidia,tegra124-uart. The -hsuart driver has had less testing
upstream, whereas the regular -uart driver is heavily used for the main
serial console. I assume you tested the new driver when enabling the
ports:-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
2016-01-26 19:27 ` Stephen Warren
@ 2016-01-26 19:35 ` Ralf Ramsauer
0 siblings, 0 replies; 10+ messages in thread
From: Ralf Ramsauer @ 2016-01-26 19:35 UTC (permalink / raw)
To: linux-arm-kernel
On 01/26/16 20:27, Stephen Warren wrote:
> On 01/26/2016 09:59 AM, Ralf Ramsauer wrote:
>> This patch enables the APB DMA high speed UARTs of the Jetson TK1. So
>> far, they were only enabled in NVidia's official BSP.
>>
>> Those additional UARTs are exposed on the expansion connector J3A2:
>>
>> UART1:
>> Pin 41: BR_UART1_TXD
>> Pin 44: BR_UART1_RXD
>>
>> UART2:
>> Pin 65: UART2_RXD
>> Pin 68: UART2_TXD
>> Pin 71: UART2_CTS_L
>> Pin 74: UART2_RTS_L
>
> The series,
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
>
> As an aside, this is perfectly OK, but I wonder why you chose to use
> compatible=nvidia,tegra124-hsuart rather than
> compatible=nvidia,tegra124-uart. The -hsuart driver has had less
> testing upstream, whereas the regular -uart driver is heavily used for
> the main serial console. I assume you tested the new driver when
> enabling the ports:-)
Let me explain it, this is how I found the typos :-)
tegra124.dtsi states:
/*
* There are two serial driver i.e. 8250 based simple serial
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
* the APB DMA based serial driver, the compatible is
* "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart".
*/
There's nothing written about the upstream stability of the hsuart
driver. So I didn't even try to use the non-hs uart driver. Nevertheless
I successfully tested both additional uarts using the hsuart driver
against 4.5-rc1 and some uart-speaking device.
Ralf
--
Ralf Ramsauer
GPG: 0x8F10049B
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: tegra: Fixed typo
2016-01-26 16:59 ` [PATCH v2 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
@ 2016-01-27 7:59 ` Alexandre Courbot
2016-01-27 8:45 ` Ralf Ramsauer
0 siblings, 1 reply; 10+ messages in thread
From: Alexandre Courbot @ 2016-01-27 7:59 UTC (permalink / raw)
To: linux-arm-kernel
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of
"Fixed typo") in your commit messages.
It would also be nice if the commit title was a little more precise
about where the typo has been corrected.
On Wed, Jan 27, 2016 at 1:59 AM, Ralf Ramsauer
<ralf@ramses-pyramidenbau.de> wrote:
> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
> ---
> arch/arm/boot/dts/tegra114.dtsi | 2 +-
> arch/arm/boot/dts/tegra124.dtsi | 2 +-
> arch/arm/boot/dts/tegra20.dtsi | 2 +-
> arch/arm/boot/dts/tegra30.dtsi | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index d845bd1..5017ed8 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -256,7 +256,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
> */
> uarta: serial at 70006000 {
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 68669f7..995289b 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -322,7 +322,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart".
> */
> uarta: serial at 0,70006000 {
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 33173e1..8fb61b9 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -309,7 +309,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra20-uart" and to enable the APB DMA based serial
> - * driver, the comptible is "nvidia,tegra20-hsuart".
> + * driver, the compatible is "nvidia,tegra20-hsuart".
> */
> uarta: serial at 70006000 {
> compatible = "nvidia,tegra20-uart";
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 313e260..c6edc8c 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -371,7 +371,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart".
> */
> uarta: serial at 70006000 {
> --
> 2.4.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: tegra: Fixed typo
2016-01-27 7:59 ` Alexandre Courbot
@ 2016-01-27 8:45 ` Ralf Ramsauer
2016-01-27 9:15 ` Alexandre Courbot
0 siblings, 1 reply; 10+ messages in thread
From: Ralf Ramsauer @ 2016-01-27 8:45 UTC (permalink / raw)
To: linux-arm-kernel
On 01/27/2016 08:59 AM, Alexandre Courbot wrote:
> Hey Ralf, thanks for following up with patches as we discussed in private!
>
> Small nit: you will want to use the active form ("Fix typo" instead of
> "Fixed typo") in your commit messages.
So even my language skills got improved ;-)
>
> It would also be nice if the commit title was a little more precise
> about where the typo has been corrected.
Uhm - as this is be pretty small non-diff-related change... Is it
necessary to send a v3 or would it also be okay to let the maintainer
amend the subject?
(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
Ralf
>
> On Wed, Jan 27, 2016 at 1:59 AM, Ralf Ramsauer
> <ralf@ramses-pyramidenbau.de> wrote:
>> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
>> ---
>> arch/arm/boot/dts/tegra114.dtsi | 2 +-
>> arch/arm/boot/dts/tegra124.dtsi | 2 +-
>> arch/arm/boot/dts/tegra20.dtsi | 2 +-
>> arch/arm/boot/dts/tegra30.dtsi | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
>> index d845bd1..5017ed8 100644
>> --- a/arch/arm/boot/dts/tegra114.dtsi
>> +++ b/arch/arm/boot/dts/tegra114.dtsi
>> @@ -256,7 +256,7 @@
>> * driver and APB DMA based serial driver for higher baudrate
>> * and performace. To enable the 8250 based driver, the compatible
>> * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
>> - * the APB DMA based serial driver, the comptible is
>> + * the APB DMA based serial driver, the compatible is
>> * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
>> */
>> uarta: serial at 70006000 {
>> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
>> index 68669f7..995289b 100644
>> --- a/arch/arm/boot/dts/tegra124.dtsi
>> +++ b/arch/arm/boot/dts/tegra124.dtsi
>> @@ -322,7 +322,7 @@
>> * driver and APB DMA based serial driver for higher baudrate
>> * and performace. To enable the 8250 based driver, the compatible
>> * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
>> - * the APB DMA based serial driver, the comptible is
>> + * the APB DMA based serial driver, the compatible is
>> * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart".
>> */
>> uarta: serial at 0,70006000 {
>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
>> index 33173e1..8fb61b9 100644
>> --- a/arch/arm/boot/dts/tegra20.dtsi
>> +++ b/arch/arm/boot/dts/tegra20.dtsi
>> @@ -309,7 +309,7 @@
>> * driver and APB DMA based serial driver for higher baudrate
>> * and performace. To enable the 8250 based driver, the compatible
>> * is "nvidia,tegra20-uart" and to enable the APB DMA based serial
>> - * driver, the comptible is "nvidia,tegra20-hsuart".
>> + * driver, the compatible is "nvidia,tegra20-hsuart".
>> */
>> uarta: serial at 70006000 {
>> compatible = "nvidia,tegra20-uart";
>> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
>> index 313e260..c6edc8c 100644
>> --- a/arch/arm/boot/dts/tegra30.dtsi
>> +++ b/arch/arm/boot/dts/tegra30.dtsi
>> @@ -371,7 +371,7 @@
>> * driver and APB DMA based serial driver for higher baudrate
>> * and performace. To enable the 8250 based driver, the compatible
>> * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable
>> - * the APB DMA based serial driver, the comptible is
>> + * the APB DMA based serial driver, the compatible is
>> * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart".
>> */
>> uarta: serial at 70006000 {
>> --
>> 2.4.10
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ralf Ramsauer
GPG: 0x8F10049B
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: tegra: Fixed typo
2016-01-27 8:45 ` Ralf Ramsauer
@ 2016-01-27 9:15 ` Alexandre Courbot
2016-01-27 14:10 ` Thierry Reding
0 siblings, 1 reply; 10+ messages in thread
From: Alexandre Courbot @ 2016-01-27 9:15 UTC (permalink / raw)
To: linux-arm-kernel
On 01/27/16 17:45, Ralf Ramsauer wrote:
> On 01/27/2016 08:59 AM, Alexandre Courbot wrote:
>> Hey Ralf, thanks for following up with patches as we discussed in private!
>>
>> Small nit: you will want to use the active form ("Fix typo" instead of
>> "Fixed typo") in your commit messages.
> So even my language skills got improved ;-)
This is grammatically correct, but using imperative form is the
convention in the kernel. As per Documentation/SubmittingPatches:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
>> It would also be nice if the commit title was a little more precise
>> about where the typo has been corrected.
> Uhm - as this is be pretty small non-diff-related change... Is it
> necessary to send a v3 or would it also be okay to let the maintainer
> amend the subject?
> (to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
Let's see what Thierry says about this.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: tegra: Fixed typo
2016-01-27 9:15 ` Alexandre Courbot
@ 2016-01-27 14:10 ` Thierry Reding
0 siblings, 0 replies; 10+ messages in thread
From: Thierry Reding @ 2016-01-27 14:10 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2016 at 06:15:50PM +0900, Alexandre Courbot wrote:
> On 01/27/16 17:45, Ralf Ramsauer wrote:
> >On 01/27/2016 08:59 AM, Alexandre Courbot wrote:
> >>Hey Ralf, thanks for following up with patches as we discussed in private!
> >>
> >>Small nit: you will want to use the active form ("Fix typo" instead of
> >>"Fixed typo") in your commit messages.
> >So even my language skills got improved ;-)
>
> This is grammatically correct, but using imperative form is the convention
> in the kernel. As per Documentation/SubmittingPatches:
>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
>
> >>It would also be nice if the commit title was a little more precise
> >>about where the typo has been corrected.
> >Uhm - as this is be pretty small non-diff-related change... Is it
> >necessary to send a v3 or would it also be okay to let the maintainer
> >amend the subject?
> >(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
>
> Let's see what Thierry says about this.
I've changed this when applying and also added a full commit message.
Doing so might arguably be a little overkill, but in doing so I realized
that the same typo was there in the Tegra132 and Tegra210 DTS includes,
so I fixed those up in a separate patch while at it. I made it a
separate patch because the arm-soc maintainers want arch/arm and
arch/arm64 changes to come in via separate branches. I did add a
Suggested-by for Ralf since he spotted the original typo, I hope that's
okay with everyone.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/24bc8ead/attachment-0001.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
2016-01-26 19:27 ` Stephen Warren
@ 2016-01-27 14:15 ` Thierry Reding
1 sibling, 0 replies; 10+ messages in thread
From: Thierry Reding @ 2016-01-27 14:15 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 26, 2016 at 05:59:18PM +0100, Ralf Ramsauer wrote:
> This patch enables the APB DMA high speed UARTs of the Jetson TK1. So
> far, they were only enabled in NVidia's official BSP.
>
> Those additional UARTs are exposed on the expansion connector J3A2:
>
> UART1:
> Pin 41: BR_UART1_TXD
> Pin 44: BR_UART1_RXD
>
> UART2:
> Pin 65: UART2_RXD
> Pin 68: UART2_TXD
> Pin 71: UART2_CTS_L
> Pin 74: UART2_RTS_L
>
> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
> ---
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/a428cfe9/attachment-0001.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-01-27 14:15 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 16:59 [PATCH v2 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1 Ralf Ramsauer
2016-01-26 16:59 ` [PATCH v2 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
2016-01-27 7:59 ` Alexandre Courbot
2016-01-27 8:45 ` Ralf Ramsauer
2016-01-27 9:15 ` Alexandre Courbot
2016-01-27 14:10 ` Thierry Reding
2016-01-26 16:59 ` [PATCH v2 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
2016-01-26 19:27 ` Stephen Warren
2016-01-26 19:35 ` Ralf Ramsauer
2016-01-27 14:15 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).