From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Move vendor's Kconfig into CCF menu section
Date: Thu, 28 Jan 2016 00:36:56 -0800 [thread overview]
Message-ID: <20160128083656.GM12841@codeaurora.org> (raw)
In-Reply-To: <6167008.u8jfFpmfhy@wuerfel>
On 01/27, Arnd Bergmann wrote:
> On Wednesday 27 January 2016 17:56:18 James Liao wrote:
> > >
> > > I think you should include this change in your patch, or as a preparation.
> > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM,
> > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that
> > > selects COMMON_CLK.
> >
> > Oops, I didn't notice there are warnings after moving these Kconfigs
> > into menu section.
> >
> > The original motivation of this patch is preventing new clk drivers
> > include their Kconfig in a wrong place, so it's not critical. Do you
> > think we should apply this patch (with your changes below) or drop this
> > patch directly?
>
>
> I think your patch is good, we just need to fix S3C24xx, which is doing
> things in a strange way for historic reasons.
So far we've taken the approach of not caring if they include
their Kconfig outside the common clk menu when all the configs
inside the Kconfig file are hidden. Of course, when they aren't
hidden this becomes a problem, but that isn't the case unless
something changed recently.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-01-28 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 7:26 [PATCH] clk: Move vendor's Kconfig into CCF menu section James Liao
2016-01-27 9:18 ` kbuild test robot
2016-01-27 9:27 ` Arnd Bergmann
2016-01-27 9:56 ` James Liao
2016-01-27 10:32 ` Arnd Bergmann
2016-01-28 8:36 ` Stephen Boyd [this message]
2016-01-28 11:31 ` Arnd Bergmann
2016-01-27 10:25 ` kbuild test robot
2016-01-27 14:48 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128083656.GM12841@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).