From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate
Date: Thu, 28 Jan 2016 09:22:16 -0800 [thread overview]
Message-ID: <20160128172215.GD19432@atomide.com> (raw)
In-Reply-To: <56A9FED1.3090903@ti.com>
* Tero Kristo <t-kristo@ti.com> [160128 03:44]:
> On 01/28/2016 01:37 PM, Tero Kristo wrote:
> >As the code in this file is being executed within irq context in some
> >cases, we must avoid the clk_get_rate which uses mutex internally.
> >Switch the code to use clk_hw_get_rate instead which is non-locking.
> >
> >Signed-off-by: Tero Kristo <t-kristo@ti.com>
>
> Ooops, sorry. Sent wrong version (read: old) of this patch, please ignore
> this one. Will re-send the correct version in a bit.
I think this is still needed as a fix for -rc cycle with cc: stable
as otherwise we have omap4 and 5 hang if PM runtime is enabled before
a suspend/resume cycle?
Regards,
Tony
> > drivers/clk/ti/dpll3xxx.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/clk/ti/dpll3xxx.c b/drivers/clk/ti/dpll3xxx.c
> >index f4dec00..7ed24bc 100644
> >--- a/drivers/clk/ti/dpll3xxx.c
> >+++ b/drivers/clk/ti/dpll3xxx.c
> >@@ -437,7 +437,8 @@ int omap3_noncore_dpll_enable(struct clk_hw *hw)
> >
> > parent = clk_hw_get_parent(hw);
> >
> >- if (clk_hw_get_rate(hw) == clk_get_rate(dd->clk_bypass)) {
> >+ if (clk_hw_get_rate(hw) ==
> >+ clk_hw_get_rate(__clk_get_hw(dd->clk_bypass))) {
> > WARN_ON(parent != __clk_get_hw(dd->clk_bypass));
> > r = _omap3_noncore_dpll_bypass(clk);
> > } else {
> >
>
next prev parent reply other threads:[~2016-01-28 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:37 [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate Tero Kristo
2016-01-28 11:43 ` Tero Kristo
2016-01-28 17:22 ` Tony Lindgren [this message]
2016-01-28 18:48 ` Tero Kristo
2016-01-28 19:00 ` Tony Lindgren
2016-01-28 19:09 ` Tero Kristo
2016-01-28 19:19 ` Tony Lindgren
2016-02-15 21:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128172215.GD19432@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).