From mboxrd@z Thu Jan  1 00:00:00 1970
From: drjones@redhat.com (Andrew Jones)
Date: Thu, 28 Jan 2016 19:12:25 +0100
Subject: [PATCH v10 10/21] KVM: ARM64: Add access handler for PMCNTENSET
 and PMCNTENCLR register
In-Reply-To: <20160128180856.GA16453@hawk.localdomain>
References: <1453866709-20324-1-git-send-email-zhaoshenglong@huawei.com>
 <1453866709-20324-11-git-send-email-zhaoshenglong@huawei.com>
 <20160128180856.GA16453@hawk.localdomain>
Message-ID: <20160128181225.GB16453@hawk.localdomain>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Jan 28, 2016 at 07:08:56PM +0100, Andrew Jones wrote:
> On Wed, Jan 27, 2016 at 11:51:38AM +0800, Shannon Zhao wrote:
> > @@ -804,10 +831,10 @@ static const struct sys_reg_desc sys_reg_descs[] = {
> >  	  access_pmcr, reset_pmcr, },
> >  	/* PMCNTENSET_EL0 */
> >  	{ Op0(0b11), Op1(0b011), CRn(0b1001), CRm(0b1100), Op2(0b001),
> > -	  trap_raz_wi },
> > +	  access_pmcnten, reset_unknown, PMCNTENSET_EL0 },
> >  	/* PMCNTENCLR_EL0 */
> >  	{ Op0(0b11), Op1(0b011), CRn(0b1001), CRm(0b1100), Op2(0b010),
> > -	  trap_raz_wi },
> > +	  access_pmcnten, NULL, PMCNTENSET_EL0 },
> 
> I don't think the reg field is needed, as the reset handler isn't
> defined and the access handler doesn't use it. Oh, and shouldn't it be
> PMCNTENCLR_EL0 anyway?

eh.. nevermind. Of course we just have the one sys_reg for both set/clr...