linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] clk: sunxi: Refactor A31 PLL6 so that it can be reused
Date: Sat, 30 Jan 2016 18:57:14 +0100	[thread overview]
Message-ID: <20160130185714.7abcf1de9ef8108c2f48c7fe@free.fr> (raw)
In-Reply-To: <1454008958-12655-2-git-send-email-maxime.ripard@free-electrons.com>

On Thu, 28 Jan 2016 20:22:38 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Remove the fixed dividers from the PLL6 driver to be able to have a
> reusable driver that can be used across several SoCs that share the same
> controller, but don't have the same set of dividers for this clock, and to
> also be reused multiple times in the same SoC, since we're droping the
> clock name.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> Changes from v2
>   - Rebased and converted over to the new factors refactoring. Fixed the
>     retrieved rate
> 
>  arch/arm/boot/dts/sun6i-a31.dtsi     | 36 ++++++++++++++++++------------------
>  arch/arm/boot/dts/sun8i-a23-a33.dtsi | 25 +++++++++++++++++--------
>  arch/arm/boot/dts/sun8i-a23.dtsi     |  2 +-
>  arch/arm/boot/dts/sun8i-a33.dtsi     |  4 ++--
>  arch/arm/boot/dts/sun8i-h3.dtsi      | 36 ++++++++++++++++++------------------
>  drivers/clk/sunxi/clk-sunxi.c        | 32 ++++++++++++++++----------------
>  6 files changed, 72 insertions(+), 63 deletions(-)

Hi Maxime,

Do you know that the DT definitions cannot be changed when they are in
the mainline kernel?

Also, for the H3 PLL periph1 (aka PLL8), why didn't you create a
'pll8x2' clock with 'pll8' as a divider?

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  parent reply	other threads:[~2016-01-30 17:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 19:22 [PATCH v3 1/2] clk: sunxi: factors: Add missing recalc pointer copy Maxime Ripard
2016-01-28 19:22 ` [PATCH v3 2/2] clk: sunxi: Refactor A31 PLL6 so that it can be reused Maxime Ripard
2016-01-29  9:56   ` Chen-Yu Tsai
2016-01-29 10:02   ` Jens Kuske
2016-01-29 10:14     ` Chen-Yu Tsai
2016-02-01 19:46       ` Maxime Ripard
2016-01-30 17:57   ` Jean-Francois Moine [this message]
2016-01-31 12:08     ` Chen-Yu Tsai
2016-01-31 14:26       ` Jean-Francois Moine
2016-02-01 20:17     ` Maxime Ripard
2016-02-02  6:52       ` Jean-Francois Moine
2016-02-03 19:07         ` Maxime Ripard
2016-01-29  6:18 ` [PATCH v3 1/2] clk: sunxi: factors: Add missing recalc pointer copy Chen-Yu Tsai
2016-01-29 10:37   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160130185714.7abcf1de9ef8108c2f48c7fe@free.fr \
    --to=moinejf@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).