[PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Javier Martinez Canillas]

Hello,

On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
we came to the conclusion that the max77686 and max77802 RTC are almost
the same with only a few differences so there shouldn't be two separate
drivers and is better to extend max77686 driver and delete rtc-max77802.

By making the driver more generic, other RTC IP blocks from Maxim PMICs
could be supported as well like the max77620.

This is a v4 of a series that do this, that address issues pointed out
in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].

I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
tested v3 on an max77686 but this version only has cosmetic changes so
it should not cause any functionality changes.

[0]: http://www.spinics.net/lists/devicetree/msg110348.html
[1]: https://lwn.net/Articles/672568/
[2]: https://lkml.org/lkml/2016/1/25/767
[3]: https://lkml.org/lkml/2016/1/26/787

Changes in v4:
- Add Andi Shyti's Reviewed-by to patch #1.
- Add Andi Shyti's Reviewed-by to patch #2.
- Add Andi Shyti's Reviewed-by to patch #3.
- Add Andi Shyti's Reviewed-by to patch #4.
- Add Krzysztof Kozlowski's Reviewed-by and Tested-by tags to patch #4.
- Add Krzysztof Kozlowski's Reviewed-by and Tested-by tags to patch #5.
- Add Krzysztof Kozlowski's Tested-by tag to patch #6.
- Add Andi Shyti's Reviewed-by tag to patch #6.
- Reverse alarm enable reg check logic. Suggeted by Krzysztof Kozlowski.
- Return early to avoid an else statement. Suggested by Andi Shyti.
- Use dev_err() instead of dev_warn() and change message.
  Suggested by Krzysztof Kozlowski and Andi Shyti.
- Change subject line and commit message of patch #7.
- Removed Laxman Dewangan's Acked-by tag since the patch changed.
- Add Krzysztof Kozlowski's Tested-by tag to patch #8.
- Add Andi Shyti's Reviewed-by tag to patch #8.

Changes in v3:
- Add Krzysztof Kozlowski's Reviewed-by and Tested-by to patch #1.
- Add Laxman Dewangan's Acked-by tag to patch #1.
- Add Krzysztof Kozlowski's Tested-by tag to patch #2.
- Add Laxman Dewangan's Acked-by tag to patch #2.
- Use ARRAY_SIZE() in all places. Suggested by Laxman Dewangan.
- Add Krzysztof Kozlowski's Tested-by tag to patch #3.
- Add Laxman Dewangan's Acked-by tag to patch #3.
- Fix max77686 delay. Suggested by Krzysztof Kozlowski.
- Assign mask to u8 instead of int. Suggested by Krzysztof Kozlowski.
- Add Laxman Dewangan's Acked-by tag to patch #4.
- Add Laxman Dewangan's Acked-by tag to patch #5.
- Add Laxman Dewangan's Acked-by tag to patch #6.
- Add Laxman Dewangan's Acked-by tag to patch #7.
- Add Laxman Dewangan's Acked-by tag to patch #8.

Changes in v2:
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #2.
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #3.
- Fix typo error in changelog. Suggested by Krzysztof Kozlowski.
- Add a max77686 prefix to rtc_driver_data. Suggested by Krzysztof Kozlowski.
- Comment about the .delay and .mask fields. Suggested by Krzysztof Kozlowski.
- Change .mask type to u8. Suggested by Krzysztof Kozlowski.
- Make .drv_data field const. Suggested by Krzysztof Kozlowski.
- Don't cast to drop const on .drv_data asign. Suggested by Krzysztof Kozlowski.
- Use platform_get_device_id() macro. Suggested by Krzysztof Kozlowski.
- Rename rtc_reg to max77686_rtc_reg_offset. Suggested by Krzysztof Kozlowski.
- Comment what's mapped by max77686_map. Suggested by Krzysztof Kozlowski.
- Use max77686_map array indexes in init. Suggested by Krzysztof Kozlowski.
- Remove REG_RTC_UPDATE1 since is not used by neither max77686 nor max77802.
- Add a MAX77802 prefix to ALARM_ENABLE_VALUE. Suggested by Krzysztof Kozlowski.
- Rename .rtcae to .alarm_enable_reg and .rtcrm to .separate_i2c_addr.
  Suggested by Krzysztof Kozlowski.
- Don't use func and LINE in error messages. Suggested by Krzysztof Kozlowski.
- Remove REG_RTC_AE2 since is not used by neither max77686 nor max77802.
- Check if REG_RTC_AE1 has a valid address before accessing it.
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #8.
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #9.
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #10.

Javier Martinez Canillas (10):
  rtc: max77686: Fix max77686_rtc_read_alarm() return value
  rtc: max77686: Use ARRAY_SIZE() instead of current array length
  rtc: max77686: Use usleep_range() instead of msleep()
  rtc: max77686: Use a driver data struct instead hard-coded values
  rtc: max77686: Add an indirection level to access RTC registers
  rtc: max77686: Add max77802 support
  rtc: max77686: Fix unsupported year message
  rtc: Remove Maxim 77802 driver
  ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol
  ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol

 arch/arm/configs/exynos_defconfig   |   1 -
 arch/arm/configs/multi_v7_defconfig |   1 -
 drivers/rtc/Kconfig                 |  10 -
 drivers/rtc/Makefile                |   1 -
 drivers/rtc/rtc-max77686.c          | 325 ++++++++++++++++++-----
 drivers/rtc/rtc-max77802.c          | 502 ------------------------------------
 6 files changed, 264 insertions(+), 576 deletions(-)
 delete mode 100644 drivers/rtc/rtc-max77802.c

-- 
2.5.0

[PATCH v4 10/10] ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol

[Javier Martinez Canillas]

The driver has been removed so the Kconfig symbol is not valid anymore.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>


---

Changes in v4: None
Changes in v3: None
Changes in v2:
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #10.

 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 314f6be2dca2..bdb42c09332c 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -664,7 +664,6 @@ CONFIG_RTC_DRV_MAX8907=y
 CONFIG_RTC_DRV_MAX8997=m
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_RK808=m
-CONFIG_RTC_DRV_MAX77802=m
 CONFIG_RTC_DRV_RS5C372=m
 CONFIG_RTC_DRV_PALMAS=y
 CONFIG_RTC_DRV_ST_LPC=y
-- 
2.5.0

[PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Andi Shyti]

Hi Javier,

In case I forgot any, for the whole patchset,

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

Andi

On Wed, Jan 27, 2016 at 12:36:36AM -0300, Javier Martinez Canillas wrote:
> Hello,
> 
> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
> we came to the conclusion that the max77686 and max77802 RTC are almost
> the same with only a few differences so there shouldn't be two separate
> drivers and is better to extend max77686 driver and delete rtc-max77802.
> 
> By making the driver more generic, other RTC IP blocks from Maxim PMICs
> could be supported as well like the max77620.
> 
> This is a v4 of a series that do this, that address issues pointed out
> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
> 
> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
> tested v3 on an max77686 but this version only has cosmetic changes so
> it should not cause any functionality changes.
> 
> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
> [1]: https://lwn.net/Articles/672568/
> [2]: https://lkml.org/lkml/2016/1/25/767
> [3]: https://lkml.org/lkml/2016/1/26/787
> 
> Changes in v4:
> - Add Andi Shyti's Reviewed-by to patch #1.
> - Add Andi Shyti's Reviewed-by to patch #2.
> - Add Andi Shyti's Reviewed-by to patch #3.
> - Add Andi Shyti's Reviewed-by to patch #4.
> - Add Krzysztof Kozlowski's Reviewed-by and Tested-by tags to patch #4.
> - Add Krzysztof Kozlowski's Reviewed-by and Tested-by tags to patch #5.
> - Add Krzysztof Kozlowski's Tested-by tag to patch #6.
> - Add Andi Shyti's Reviewed-by tag to patch #6.
> - Reverse alarm enable reg check logic. Suggeted by Krzysztof Kozlowski.
> - Return early to avoid an else statement. Suggested by Andi Shyti.
> - Use dev_err() instead of dev_warn() and change message.
>   Suggested by Krzysztof Kozlowski and Andi Shyti.
> - Change subject line and commit message of patch #7.
> - Removed Laxman Dewangan's Acked-by tag since the patch changed.
> - Add Krzysztof Kozlowski's Tested-by tag to patch #8.
> - Add Andi Shyti's Reviewed-by tag to patch #8.
> 
> Changes in v3:
> - Add Krzysztof Kozlowski's Reviewed-by and Tested-by to patch #1.
> - Add Laxman Dewangan's Acked-by tag to patch #1.
> - Add Krzysztof Kozlowski's Tested-by tag to patch #2.
> - Add Laxman Dewangan's Acked-by tag to patch #2.
> - Use ARRAY_SIZE() in all places. Suggested by Laxman Dewangan.
> - Add Krzysztof Kozlowski's Tested-by tag to patch #3.
> - Add Laxman Dewangan's Acked-by tag to patch #3.
> - Fix max77686 delay. Suggested by Krzysztof Kozlowski.
> - Assign mask to u8 instead of int. Suggested by Krzysztof Kozlowski.
> - Add Laxman Dewangan's Acked-by tag to patch #4.
> - Add Laxman Dewangan's Acked-by tag to patch #5.
> - Add Laxman Dewangan's Acked-by tag to patch #6.
> - Add Laxman Dewangan's Acked-by tag to patch #7.
> - Add Laxman Dewangan's Acked-by tag to patch #8.
> 
> Changes in v2:
> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #2.
> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #3.
> - Fix typo error in changelog. Suggested by Krzysztof Kozlowski.
> - Add a max77686 prefix to rtc_driver_data. Suggested by Krzysztof Kozlowski.
> - Comment about the .delay and .mask fields. Suggested by Krzysztof Kozlowski.
> - Change .mask type to u8. Suggested by Krzysztof Kozlowski.
> - Make .drv_data field const. Suggested by Krzysztof Kozlowski.
> - Don't cast to drop const on .drv_data asign. Suggested by Krzysztof Kozlowski.
> - Use platform_get_device_id() macro. Suggested by Krzysztof Kozlowski.
> - Rename rtc_reg to max77686_rtc_reg_offset. Suggested by Krzysztof Kozlowski.
> - Comment what's mapped by max77686_map. Suggested by Krzysztof Kozlowski.
> - Use max77686_map array indexes in init. Suggested by Krzysztof Kozlowski.
> - Remove REG_RTC_UPDATE1 since is not used by neither max77686 nor max77802.
> - Add a MAX77802 prefix to ALARM_ENABLE_VALUE. Suggested by Krzysztof Kozlowski.
> - Rename .rtcae to .alarm_enable_reg and .rtcrm to .separate_i2c_addr.
>   Suggested by Krzysztof Kozlowski.
> - Don't use func and LINE in error messages. Suggested by Krzysztof Kozlowski.
> - Remove REG_RTC_AE2 since is not used by neither max77686 nor max77802.
> - Check if REG_RTC_AE1 has a valid address before accessing it.
> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #8.
> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #9.
> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #10.
> 
> Javier Martinez Canillas (10):
>   rtc: max77686: Fix max77686_rtc_read_alarm() return value
>   rtc: max77686: Use ARRAY_SIZE() instead of current array length
>   rtc: max77686: Use usleep_range() instead of msleep()
>   rtc: max77686: Use a driver data struct instead hard-coded values
>   rtc: max77686: Add an indirection level to access RTC registers
>   rtc: max77686: Add max77802 support
>   rtc: max77686: Fix unsupported year message
>   rtc: Remove Maxim 77802 driver
>   ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol
>   ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol
> 
>  arch/arm/configs/exynos_defconfig   |   1 -
>  arch/arm/configs/multi_v7_defconfig |   1 -
>  drivers/rtc/Kconfig                 |  10 -
>  drivers/rtc/Makefile                |   1 -
>  drivers/rtc/rtc-max77686.c          | 325 ++++++++++++++++++-----
>  drivers/rtc/rtc-max77802.c          | 502 ------------------------------------
>  6 files changed, 264 insertions(+), 576 deletions(-)
>  delete mode 100644 drivers/rtc/rtc-max77802.c
> 
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Alexandre Belloni]

Hi,

On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote :
> Hello,
> 
> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
> we came to the conclusion that the max77686 and max77802 RTC are almost
> the same with only a few differences so there shouldn't be two separate
> drivers and is better to extend max77686 driver and delete rtc-max77802.
> 
> By making the driver more generic, other RTC IP blocks from Maxim PMICs
> could be supported as well like the max77620.
> 
> This is a v4 of a series that do this, that address issues pointed out
> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
> 
> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
> tested v3 on an max77686 but this version only has cosmetic changes so
> it should not cause any functionality changes.
> 
> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
> [1]: https://lwn.net/Articles/672568/
> [2]: https://lkml.org/lkml/2016/1/25/767
> [3]: https://lkml.org/lkml/2016/1/26/787
> 

I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about
what I should do with the defconfig changes.

Thanks!


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Krzysztof Kozlowski]

W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze:
> Hi,
> 
> On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote :
>> Hello,
>>
>> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
>> we came to the conclusion that the max77686 and max77802 RTC are almost
>> the same with only a few differences so there shouldn't be two separate
>> drivers and is better to extend max77686 driver and delete rtc-max77802.
>>
>> By making the driver more generic, other RTC IP blocks from Maxim PMICs
>> could be supported as well like the max77620.
>>
>> This is a v4 of a series that do this, that address issues pointed out
>> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
>>
>> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
>> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
>> tested v3 on an max77686 but this version only has cosmetic changes so
>> it should not cause any functionality changes.
>>
>> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
>> [1]: https://lwn.net/Articles/672568/
>> [2]: https://lkml.org/lkml/2016/1/25/767
>> [3]: https://lkml.org/lkml/2016/1/26/787
>>
> 
> I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about
> what I should do with the defconfig changes.

To avoid conflicts they could go through samsung-soc tree. I could pick
them if you provide me a tag with rest of patchset (dependencies).

Would that be okay for you?

Best regards,
Krzysztof

[rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Alexandre Belloni]

On 31/01/2016 at 21:11:00 +0900, Krzysztof Kozlowski wrote :
> W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze:
> > Hi,
> > 
> > On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote :
> >> Hello,
> >>
> >> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
> >> we came to the conclusion that the max77686 and max77802 RTC are almost
> >> the same with only a few differences so there shouldn't be two separate
> >> drivers and is better to extend max77686 driver and delete rtc-max77802.
> >>
> >> By making the driver more generic, other RTC IP blocks from Maxim PMICs
> >> could be supported as well like the max77620.
> >>
> >> This is a v4 of a series that do this, that address issues pointed out
> >> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
> >>
> >> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
> >> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
> >> tested v3 on an max77686 but this version only has cosmetic changes so
> >> it should not cause any functionality changes.
> >>
> >> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
> >> [1]: https://lwn.net/Articles/672568/
> >> [2]: https://lkml.org/lkml/2016/1/25/767
> >> [3]: https://lkml.org/lkml/2016/1/26/787
> >>
> > 
> > I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about
> > what I should do with the defconfig changes.
> 
> To avoid conflicts they could go through samsung-soc tree. I could pick
> them if you provide me a tag with rest of patchset (dependencies).
> 
> Would that be okay for you?
> 

Let's do that, I've prepared a tag, rtc-max77686-4.6 with all the
max77686 material collected until now.  If I need to rebase rtc-next,
I'll rebase on top of that.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

[Krzysztof Kozlowski]

On 05.02.2016 07:56, Alexandre Belloni wrote:
> On 31/01/2016 at 21:11:00 +0900, Krzysztof Kozlowski wrote :
>> W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze:
>>> Hi,
>>>
>>> On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote :
>>>> Hello,
>>>>
>>>> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
>>>> we came to the conclusion that the max77686 and max77802 RTC are almost
>>>> the same with only a few differences so there shouldn't be two separate
>>>> drivers and is better to extend max77686 driver and delete rtc-max77802.
>>>>
>>>> By making the driver more generic, other RTC IP blocks from Maxim PMICs
>>>> could be supported as well like the max77620.
>>>>
>>>> This is a v4 of a series that do this, that address issues pointed out
>>>> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
>>>>
>>>> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
>>>> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
>>>> tested v3 on an max77686 but this version only has cosmetic changes so
>>>> it should not cause any functionality changes.
>>>>
>>>> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
>>>> [1]: https://lwn.net/Articles/672568/
>>>> [2]: https://lkml.org/lkml/2016/1/25/767
>>>> [3]: https://lkml.org/lkml/2016/1/26/787
>>>>
>>>
>>> I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about
>>> what I should do with the defconfig changes.
>>
>> To avoid conflicts they could go through samsung-soc tree. I could pick
>> them if you provide me a tag with rest of patchset (dependencies).
>>
>> Would that be okay for you?
>>
> 
> Let's do that, I've prepared a tag, rtc-max77686-4.6 with all the
> max77686 material collected until now.  If I need to rebase rtc-next,
> I'll rebase on top of that.

Thanks, I pulled the tag, applied patches #9 and #10 and pushed out to
the for-next.

Best regards,
Krzysztof