From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] Documentation: gpio: Update description for X-Gene standby GPIO controller DTS binding
Date: Mon, 1 Feb 2016 09:35:02 -0600 [thread overview]
Message-ID: <20160201153502.GA19725@rob-hp-laptop> (raw)
In-Reply-To: <1454041735-8434-3-git-send-email-qnguyen@apm.com>
On Fri, Jan 29, 2016 at 11:28:54AM +0700, Quan Nguyen wrote:
> Update description for X-Gene standby GPIO controller DTS binding to
> support GPIO line configuration as input, output or external IRQ pin.
>
> Signed-off-by: Y Vo <yvo@apm.com>
> Signed-off-by: Quan Nguyen <qnguyen@apm.com>
> ---
> .../devicetree/bindings/gpio/gpio-xgene-sb.txt | 47 ++++++++++++++++++----
> 1 file changed, 40 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-xgene-sb.txt b/Documentation/devicetree/bindings/gpio/gpio-xgene-sb.txt
> index dae1300..7b8b4cb 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-xgene-sb.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-xgene-sb.txt
> @@ -1,10 +1,20 @@
> APM X-Gene Standby GPIO controller bindings
>
> -This is a gpio controller in the standby domain.
> -
> -There are 20 GPIO pins from 0..21. There is no GPIO_DS14 or GPIO_DS15,
> -only GPIO_DS8..GPIO_DS13 support interrupts. The IRQ mapping
> -is currently 1-to-1 on interrupts 0x28 thru 0x2d.
> +This is a gpio controller in the standby domain. It also supports interrupt in
> +some particular pins which are sourced to its parent interrupt controller
> +as diagram below:
> + +-----------------+
> + | X-Gene standby |
> + | GPIO controller +--------- GPIO_0
> ++------------+ | | ...
> +| Parent IRQ | | +--------- GPIO_8/EXT_INT_0
> +| controller | EXT_INT_0 | | ...
> +| (GICv2) +-------------+ +--------- GPIO_[N+8]/EXT_INT_N
> +| | ... | |
> +| | EXT_INT_N | +--------- GPIO_[N+9]
> +| +-------------+ | ...
> +| | | +--------- GPIO_MAX
> ++------------+ +-----------------+
>
> Required properties:
> - compatible: "apm,xgene-gpio-sb" for the X-Gene Standby GPIO controller
> @@ -15,10 +25,18 @@ Required properties:
> 0 = active high
> 1 = active low
> - gpio-controller: Marks the device node as a GPIO controller.
> -- interrupts: Shall contain exactly 6 interrupts.
> +- interrupts: The EXT_INT_0 parent interrupt resource must be listed first.
> +- interrupt-parent: Phandle of the parent interrupt controller.
> +- interrupt-cells: Should be two.
> + - first cell is 0-N coresponding for EXT_INT_0 to EXT_INT_N.
> + - second cell is used to specify flags.
> +- interrupt-controller: Marks the device node as an interrupt controller.
> +- apm,nr-gpios: Optional, specify number of gpios pin.
> +- apm,nr-irqs: Optional, specify number of interrupt pins.
When is this not 6?
> +- apm,irq-start: Optional, specify lowest gpio pin support interrupt.
What determines this value? What value is assumed if not present?
Rob
next prev parent reply other threads:[~2016-02-01 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 4:28 [PATCH v5 0/3] Enable X-Gene standby GPIO as interrupt controller Quan Nguyen
2016-01-29 4:28 ` [PATCH v5 1/3] gpio: xgene: " Quan Nguyen
2016-02-10 10:58 ` Linus Walleij
2016-02-10 15:09 ` Marc Zyngier
2016-02-11 16:35 ` Quan Nguyen
2016-02-15 23:26 ` Linus Walleij
2016-01-29 4:28 ` [PATCH v5 2/3] Documentation: gpio: Update description for X-Gene standby GPIO controller DTS binding Quan Nguyen
2016-02-01 15:35 ` Rob Herring [this message]
2016-02-02 1:46 ` Quan Nguyen
2016-02-12 14:36 ` Rob Herring
2016-02-13 3:21 ` Quan Nguyen
2016-01-29 4:28 ` [PATCH v5 3/3] arm64: dts: Update X-Gene standby GPIO controller DTS entries Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201153502.GA19725@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox