From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: asm: Explicitly include linux/personality.h in asm/page.h
Date: Tue, 2 Feb 2016 16:48:18 +0000 [thread overview]
Message-ID: <20160202164817.GM10166@arm.com> (raw)
In-Reply-To: <20160128144610.GA2380@ulmo>
On Thu, Jan 28, 2016 at 03:46:10PM +0100, Thierry Reding wrote:
> On Thu, Jan 28, 2016 at 02:14:26PM +0000, Catalin Marinas wrote:
> > On Thu, Jan 28, 2016 at 12:44:17PM +0000, Mark Brown wrote:
> > > On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
> > > > asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
> > > > explicitly include it causing build failures in -next where whatever was
> > > > causing it to be implicitly included has changed to remove that
> > > > inclusion. Add an explicit inclusion to fix this.
> > >
> > > Argh, sorry - this causes problems further down the line with linking
> > > vdso.lds due to enums getting into the linker script and upsetting the
> > > linker (there are several compile errors today so it was masked).
> >
> > You can move the include further down after the #ifndef __ASSEMBLY__
>
> Indeed, here's what I've been using to successfully complete ARM64 test
> builds:
>
> --- >8 ---
> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
> index 9b2f5a9d019d..ae615b9d9a55 100644
> --- a/arch/arm64/include/asm/page.h
> +++ b/arch/arm64/include/asm/page.h
> @@ -39,6 +39,7 @@
>
> #ifndef __ASSEMBLY__
>
> +#include <linux/personality.h> /* for READ_IMPLIES_EXEC */
> #include <asm/pgtable-types.h>
>
> extern void __cpu_clear_user_page(void *p, unsigned long user);
I see this has ended up in linux-next, but I'm not sure whether or not
it's actually queued someplace for 4.6. Any ideas?
If not, I can take it (or some derivative) through arm64 as a fix for
-rc3.
Will
next prev parent reply other threads:[~2016-02-02 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 12:18 [PATCH] arm64: asm: Explicitly include linux/personality.h in asm/page.h Mark Brown
2016-01-28 12:44 ` Mark Brown
2016-01-28 14:14 ` Catalin Marinas
2016-01-28 14:46 ` Thierry Reding
2016-02-02 16:48 ` Will Deacon [this message]
2016-02-02 19:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202164817.GM10166@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).