From: k@japko.eu (Krzysztof Adamski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets
Date: Wed, 3 Feb 2016 23:21:17 +0100 [thread overview]
Message-ID: <20160203222117.GA12071@box2.japko.eu> (raw)
In-Reply-To: <20160203123534.GG4652@lukather>
On Wed, Feb 03, 2016 at 01:35:34PM +0100, Maxime Ripard wrote:
>Hi,
>
>On Tue, Feb 02, 2016 at 10:21:50PM +0100, Krzysztof Adamski wrote:
>> APB0 is bearly mentioned in H3 User Manual and it is only setup in the
>> Allwinners kernel dump for CIR. I have verified experimentally that the
>> gate for R_PIO exists and works, though. There are probably other gates
>> there but I don't know their order right now and I don't have access to
>> their peripherals on my board to test them.
>>
>> Signed-off-by: Krzysztof Adamski <k@japko.eu>
>> ---
>> arch/arm/boot/dts/sun8i-h3.dtsi | 32 ++++++++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>> index 1524130e..ce35e93 100644
>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>> @@ -276,6 +276,32 @@
>> clocks = <&osc24M>, <&pll6 1>, <&pll5>;
>> clock-output-names = "mbus";
>> };
>> +
>> + ahb0: ahb0_clk {
>> + compatible = "fixed-factor-clock";
>> + #clock-cells = <0>;
>> + clock-div = <1>;
>> + clock-mult = <1>;
>> + clocks = <&osc24M>, <&osc32k>;
>> + clock-output-names = "ahb0";
>> + };
>
>I'm not sure what you mean there. The fixed factor clocks only take a
>single parent, and you provided two.
True, I that's actually some stupid leftover. As mentioned in the commit
message I didn't really know how the clock tree looks like here so I
wanted to just pretend it's connectet to osc24M. After some experiments
I think that 0x01f0140c register does not exist on H3 and I was finally
(hopefully) able to understand how this clock is set up in Allwinner's
code. So I changed the clock to factors clock with possible osc32k and
osc24M parrents. Will send it in v3.
next prev parent reply other threads:[~2016-02-03 22:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 21:21 [PATCH v2 0/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
2016-02-02 21:21 ` [PATCH v2 1/5] clk: sunxi: Add apb0 gates for H3 Krzysztof Adamski
2016-02-03 7:04 ` Chen-Yu Tsai
2016-02-02 21:21 ` [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets Krzysztof Adamski
2016-02-03 12:35 ` Maxime Ripard
2016-02-03 22:21 ` Krzysztof Adamski [this message]
2016-02-03 23:44 ` Krzysztof Adamski
2016-02-02 21:21 ` [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
2016-02-03 12:36 ` Maxime Ripard
2016-02-11 13:21 ` Linus Walleij
2016-02-15 8:08 ` [linux-sunxi] " Krzysztof Adamski
2016-02-15 9:17 ` Linus Walleij
2016-02-18 15:03 ` [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Krzysztof Adamski
2016-02-18 17:07 ` Chen-Yu Tsai
2016-02-18 19:42 ` [linux-sunxi] " Krzysztof Adamski
2016-02-18 19:49 ` [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation Krzysztof Adamski
2016-02-21 18:29 ` Chen-Yu Tsai
2016-02-25 9:27 ` Linus Walleij
2016-02-02 21:21 ` [PATCH v2 4/5] ARM: dts: sun8i-h3: Add R_PIO controller node to the dtsi Krzysztof Adamski
2016-02-02 22:19 ` [linux-sunxi] " Julian Calaby
2016-02-02 21:21 ` [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set Krzysztof Adamski
2016-02-03 7:02 ` Chen-Yu Tsai
2016-02-11 13:17 ` Linus Walleij
2016-02-11 13:20 ` [linux-sunxi] " Krzysztof Adamski
2016-02-11 13:50 ` Linus Walleij
2016-02-11 13:21 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203222117.GA12071@box2.japko.eu \
--to=k@japko.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).