* [PATCH 1/2] ARM: remove bzImage target
@ 2016-02-08 5:04 Masahiro Yamada
2016-02-08 5:04 ` [PATCH 2/2] ARM: descend into arch/arm/boot only once to generate boot images Masahiro Yamada
2016-02-08 12:18 ` [PATCH 1/2] ARM: remove bzImage target Russell King - ARM Linux
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-02-08 5:04 UTC (permalink / raw)
To: linux-arm-kernel
bzImage has been just an alias for zImage for more than a decade.
It would not hurt to delete it.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/Makefile | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 46fb1ca..d6d453f 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -312,13 +312,10 @@ boot := arch/arm/boot
archprepare:
$(Q)$(MAKE) $(build)=arch/arm/tools include/generated/mach-types.h
-# Convert bzImage to zImage
-bzImage: zImage
-
BOOT_TARGETS = zImage Image xipImage bootpImage uImage
INSTALL_TARGETS = zinstall uinstall install
-PHONY += bzImage $(BOOT_TARGETS) $(INSTALL_TARGETS)
+PHONY += $(BOOT_TARGETS) $(INSTALL_TARGETS)
bootpImage uImage: zImage
zImage: Image
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] ARM: descend into arch/arm/boot only once to generate boot images
2016-02-08 5:04 [PATCH 1/2] ARM: remove bzImage target Masahiro Yamada
@ 2016-02-08 5:04 ` Masahiro Yamada
2016-02-08 12:18 ` [PATCH 1/2] ARM: remove bzImage target Russell King - ARM Linux
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-02-08 5:04 UTC (permalink / raw)
To: linux-arm-kernel
Commit 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not
generate invalid images") fixed bad images generation in the parallel
building, but it is not efficient to descend into arch/arm/boot over
and over again. It is also clumsy to display the same log message
"Kernel: arch/arm/boot/Image is ready" a couple of times.
$ make ARCH=arm UIMAGE_LOADADDR=0x80208000 all uImage
[snip]
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/zImage is ready
Building modules, stage 2.
MODPOST 279 modules
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/zImage is ready
UIMAGE arch/arm/boot/uImage
Image Name: Linux-4.5.0-rc3
Created: Mon Feb 8 13:22:53 2016
Image Type: ARM Linux Kernel Image (uncompressed)
Data Size: 6768768 Bytes = 6610.12 kB = 6.46 MB
Load Address: 80208000
Entry Point: 80208000
Image arch/arm/boot/uImage is ready
This commit allows arch/arm/boot/Makefile to build boot images at once
instead of generating them one by one. Of course, it works correctly
also in parallel building.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/Makefile | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index d6d453f..6db669e 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -315,13 +315,17 @@ archprepare:
BOOT_TARGETS = zImage Image xipImage bootpImage uImage
INSTALL_TARGETS = zinstall uinstall install
-PHONY += $(BOOT_TARGETS) $(INSTALL_TARGETS)
+PHONY += $(BOOT_TARGETS) $(INSTALL_TARGETS) __build_images
-bootpImage uImage: zImage
-zImage: Image
+$(BOOT_TARGETS): __build_images
+ @:
-$(BOOT_TARGETS): vmlinux
- $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
+__build_images: vmlinux
+ $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) \
+ $(addprefix $(boot)/,
+ $(sort $(filter $(BOOT_TARGETS),$(MAKECMDGOALS)) \
+ $(if $(filter all,$(MAKECMDGOALS)), $(KBUILD_IMAGE)) \
+ $(if $(MAKECMDGOALS),,$(KBUILD_IMAGE))))
$(INSTALL_TARGETS):
$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/2] ARM: remove bzImage target
2016-02-08 5:04 [PATCH 1/2] ARM: remove bzImage target Masahiro Yamada
2016-02-08 5:04 ` [PATCH 2/2] ARM: descend into arch/arm/boot only once to generate boot images Masahiro Yamada
@ 2016-02-08 12:18 ` Russell King - ARM Linux
1 sibling, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2016-02-08 12:18 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 08, 2016 at 02:04:58PM +0900, Masahiro Yamada wrote:
> bzImage has been just an alias for zImage for more than a decade.
> It would not hurt to delete it.
NAK. bzImage exists for compatibility with build scripts, removing it
is likely to break people's scripts. It does no harm to keep it.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-08 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 5:04 [PATCH 1/2] ARM: remove bzImage target Masahiro Yamada
2016-02-08 5:04 ` [PATCH 2/2] ARM: descend into arch/arm/boot only once to generate boot images Masahiro Yamada
2016-02-08 12:18 ` [PATCH 1/2] ARM: remove bzImage target Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).