From: robert.richter@caviumnetworks.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address
Date: Mon, 8 Feb 2016 14:48:35 +0100 [thread overview]
Message-ID: <20160208134835.GX24726@rric.localdomain> (raw)
In-Reply-To: <56B8987D.7000901@cogentembedded.com>
On 08.02.16 16:30:37, Sergei Shtylyov wrote:
> >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
> > goto out;
> >
> > if (!is_valid_ether_addr(mac)) {
> >+ dev_warn(dev, "MAC address invalid: %pM\n", mac);
>
> dev_er(), maybe?
Since the driver may continue, my choice was a warning only.
-Robert
>
> > ret = -EINVAL;
> > goto out;
> > }
> >
> >+ dev_info(dev, "MAC address set to: %pM\n", mac);
> >+
> > memcpy(dst, mac, ETH_ALEN);
> > out:
> > return ret;
> [...]
next prev parent reply other threads:[~2016-02-08 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 12:07 [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations sunil.kovvuri at gmail.com
2016-02-08 12:07 ` [PATCH 1/6] net, thunderx: Add TX timeout and RX buffer alloc failure stats sunil.kovvuri at gmail.com
2016-02-08 12:07 ` [PATCH 2/6] net: thunderx: Use napi_schedule_irqoff() sunil.kovvuri at gmail.com
2016-02-08 12:07 ` [PATCH 3/6] net: thunderx: Assign affinity hints to vf's interrupts sunil.kovvuri at gmail.com
2016-02-08 12:07 ` [PATCH 4/6] net: thunderx: bgx: Use standard firmware node infrastructure sunil.kovvuri at gmail.com
2016-02-08 12:07 ` [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address sunil.kovvuri at gmail.com
2016-02-08 13:30 ` Sergei Shtylyov
2016-02-08 13:48 ` Robert Richter [this message]
2016-02-08 13:49 ` Bjørn Mork
2016-02-08 13:51 ` Sergei Shtylyov
2016-02-08 12:07 ` [PATCH 6/6] net: thunderx: Alloc higher order pages when pagesize is small sunil.kovvuri at gmail.com
2016-02-11 13:26 ` [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations Sunil Kovvuri
2016-02-11 14:33 ` David Miller
2016-02-11 15:12 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208134835.GX24726@rric.localdomain \
--to=robert.richter@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox