linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox
@ 2016-02-09  9:29 codekipper at gmail.com
  2016-02-09  9:31 ` Hans de Goede
  2016-02-09 18:34 ` Maxime Ripard
  0 siblings, 2 replies; 4+ messages in thread
From: codekipper at gmail.com @ 2016-02-09  9:29 UTC (permalink / raw)
  To: linux-arm-kernel

From: Marcus Cooper <codekipper@gmail.com>

Enable the otg/drc usb controller on the Itead Ibox device.

Note this board has the otg-vbus connected directly to the 5v-dcc of
the board, so there is no vbus0 regulator, nor vbus0-det.

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
Changes since v1:
- Added comment concerning vbus0 regulator and detection to commit message

---
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     | 14 ++++++++++++++
 arch/arm/boot/dts/sunxi-itead-core-common.dtsi |  9 +++++++++
 2 files changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
index 661c21d..a512581 100644
--- a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
+++ b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
@@ -118,8 +118,22 @@
 		allwinner,drive = <SUN4I_PINCTRL_20_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
+
+	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
+		allwinner,pins = "PH4";
+		allwinner,function = "gpio_in";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
 };
 
 &reg_ahci_5v {
 	status = "okay";
 };
+
+&usbphy {
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_id_detect_pin>;
+	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
index 2565d51..d22eea3 100644
--- a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
+++ b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
@@ -88,6 +88,10 @@
 	status = "okay";
 };
 
+&otg_sram {
+	status = "okay";
+};
+
 #include "axp209.dtsi"
 
 &reg_dcdc2 {
@@ -129,6 +133,11 @@
 	status = "okay";
 };
 
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
 &usbphy {
 	usb1_vbus-supply = <&reg_usb1_vbus>;
 	usb2_vbus-supply = <&reg_usb2_vbus>;
-- 
2.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox
  2016-02-09  9:29 [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox codekipper at gmail.com
@ 2016-02-09  9:31 ` Hans de Goede
  2016-02-09 18:34 ` Maxime Ripard
  1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2016-02-09  9:31 UTC (permalink / raw)
  To: linux-arm-kernel

Jo.

On 09-02-16 10:29, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Enable the otg/drc usb controller on the Itead Ibox device.
>
> Note this board has the otg-vbus connected directly to the 5v-dcc of
> the board, so there is no vbus0 regulator, nor vbus0-det.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
> Changes since v1:
> - Added comment concerning vbus0 regulator and detection to commit message

Thanks patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


>
> ---
>   arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     | 14 ++++++++++++++
>   arch/arm/boot/dts/sunxi-itead-core-common.dtsi |  9 +++++++++
>   2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> index 661c21d..a512581 100644
> --- a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> @@ -118,8 +118,22 @@
>   		allwinner,drive = <SUN4I_PINCTRL_20_MA>;
>   		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>   	};
> +
> +	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
> +		allwinner,pins = "PH4";
> +		allwinner,function = "gpio_in";
> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +	};
>   };
>
>   &reg_ahci_5v {
>   	status = "okay";
>   };
> +
> +&usbphy {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&usb0_id_detect_pin>;
> +	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> index 2565d51..d22eea3 100644
> --- a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> +++ b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> @@ -88,6 +88,10 @@
>   	status = "okay";
>   };
>
> +&otg_sram {
> +	status = "okay";
> +};
> +
>   #include "axp209.dtsi"
>
>   &reg_dcdc2 {
> @@ -129,6 +133,11 @@
>   	status = "okay";
>   };
>
> +&usb_otg {
> +	dr_mode = "otg";
> +	status = "okay";
> +};
> +
>   &usbphy {
>   	usb1_vbus-supply = <&reg_usb1_vbus>;
>   	usb2_vbus-supply = <&reg_usb2_vbus>;
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox
  2016-02-09  9:29 [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox codekipper at gmail.com
  2016-02-09  9:31 ` Hans de Goede
@ 2016-02-09 18:34 ` Maxime Ripard
       [not found]   ` <CAEKpxBncN5-WYTNTw+8jfZypiMNfJt=55qEx2zTPfvZmjr9XdQ@mail.gmail.com>
  1 sibling, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2016-02-09 18:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Tue, Feb 09, 2016 at 10:29:16AM +0100, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
> 
> Enable the otg/drc usb controller on the Itead Ibox device.
> 
> Note this board has the otg-vbus connected directly to the 5v-dcc of
> the board, so there is no vbus0 regulator, nor vbus0-det.
> 
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
> Changes since v1:
> - Added comment concerning vbus0 regulator and detection to commit message
> 
> ---
>  arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     | 14 ++++++++++++++
>  arch/arm/boot/dts/sunxi-itead-core-common.dtsi |  9 +++++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> index 661c21d..a512581 100644
> --- a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
> @@ -118,8 +118,22 @@
>  		allwinner,drive = <SUN4I_PINCTRL_20_MA>;
>  		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>  	};
> +
> +	usb0_id_detect_pin: usb0_id_detect_pin at 0 {
> +		allwinner,pins = "PH4";
> +		allwinner,function = "gpio_in";
> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +	};
>  };
>  
>  &reg_ahci_5v {
>  	status = "okay";
>  };
> +
> +&usbphy {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&usb0_id_detect_pin>;
> +	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> index 2565d51..d22eea3 100644
> --- a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> +++ b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
> @@ -88,6 +88,10 @@
>  	status = "okay";
>  };
>  
> +&otg_sram {
> +	status = "okay";
> +};
> +
>  #include "axp209.dtsi"
>  
>  &reg_dcdc2 {
> @@ -129,6 +133,11 @@
>  	status = "okay";
>  };
>  
> +&usb_otg {
> +	dr_mode = "otg";

If VBUS is tied to 5V, without anyway to disable it, then it cannot do
OTG.

The mode it can do is host.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160209/0f3e8167/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox
       [not found]   ` <CAEKpxBncN5-WYTNTw+8jfZypiMNfJt=55qEx2zTPfvZmjr9XdQ@mail.gmail.com>
@ 2016-02-09 19:54     ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2016-02-09 19:54 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 02/09/2016 08:10 PM, Code Kipper wrote:
>
>
> On 9 February 2016 at 19:34, Maxime Ripard <maxime.ripard at free-electrons.com <mailto:maxime.ripard@free-electrons.com>> wrote:
>  > Hi,
>  >
>  > On Tue, Feb 09, 2016 at 10:29:16AM +0100, codekipper at gmail.com <mailto:codekipper@gmail.com> wrote:
>  >> From: Marcus Cooper <codekipper at gmail.com <mailto:codekipper@gmail.com>>
>  >>
>  >> Enable the otg/drc usb controller on the Itead Ibox device.
>  >>
>  >> Note this board has the otg-vbus connected directly to the 5v-dcc of
>  >> the board, so there is no vbus0 regulator, nor vbus0-det.
>  >>
>  >> Signed-off-by: Marcus Cooper <codekipper at gmail.com <mailto:codekipper@gmail.com>>
>  >> ---
>  >> Changes since v1:
>  >> - Added comment concerning vbus0 regulator and detection to commit message
>  >>
>  >> ---
>  >>  arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     | 14 ++++++++++++++
>  >>  arch/arm/boot/dts/sunxi-itead-core-common.dtsi |  9 +++++++++
>  >>  2 files changed, 23 insertions(+)
>  >>
>  >> diff --git a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
>  >> index 661c21d..a512581 100644
>  >> --- a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
>  >> +++ b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
>  >> @@ -118,8 +118,22 @@
>  >>               allwinner,drive = <SUN4I_PINCTRL_20_MA>;
>  >>               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>  >>       };
>  >> +
>  >> +     usb0_id_detect_pin: usb0_id_detect_pin at 0 {
>  >> +             allwinner,pins = "PH4";
>  >> +             allwinner,function = "gpio_in";
>  >> +             allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>  >> +             allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>  >> +     };
>  >>  };
>  >>
>  >>  &reg_ahci_5v {
>  >>       status = "okay";
>  >>  };
>  >> +
>  >> +&usbphy {
>  >> +     pinctrl-names = "default";
>  >> +     pinctrl-0 = <&usb0_id_detect_pin>;
>  >> +     usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
>  >> +     status = "okay";
>  >> +};
>  >> diff --git a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
>  >> index 2565d51..d22eea3 100644
>  >> --- a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
>  >> +++ b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
>  >> @@ -88,6 +88,10 @@
>  >>       status = "okay";
>  >>  };
>  >>
>  >> +&otg_sram {
>  >> +     status = "okay";
>  >> +};
>  >> +
>  >>  #include "axp209.dtsi"
>  >>
>  >>  &reg_dcdc2 {
>  >> @@ -129,6 +133,11 @@
>  >>       status = "okay";
>  >>  };
>  >>
>  >> +&usb_otg {
>  >> +     dr_mode = "otg";
>  >
>  > If VBUS is tied to 5V, without anyway to disable it, then it cannot do
>  > OTG.
>  >
>  > The mode it can do is host.
> This is the same patch as what was applied to cubieboard2 https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts?id=b8962f7ee700580a148e05eceb2302bcfc59ffbc which it looks like this hardware copies. I can power the Ibox using this USB socket and when I plug in a usb2ethernet device then it is detected.

Right, the otg port on the cubieboard can work in otg mode just fine, as long as either the
otg is the only power supply, or the 5v supplied to the power barrel comes from the same
source as the otg 5v. Note that only allowing host mode does not take away this limitation
as the 2 5v pins are hardwired together, so we might just as well offer otg support.

Regards,

Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-09 19:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09  9:29 [linux-sunxi][PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox codekipper at gmail.com
2016-02-09  9:31 ` Hans de Goede
2016-02-09 18:34 ` Maxime Ripard
     [not found]   ` <CAEKpxBncN5-WYTNTw+8jfZypiMNfJt=55qEx2zTPfvZmjr9XdQ@mail.gmail.com>
2016-02-09 19:54     ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).