From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/14] mfd: intel_quark_i2c_gpio: Use clkdev_create()
Date: Wed, 10 Feb 2016 10:35:04 -0800 [thread overview]
Message-ID: <20160210183504.GG30978@codeaurora.org> (raw)
In-Reply-To: <20160210162349.GJ3782@x1>
On 02/10, Lee Jones wrote:
> On Mon, 08 Feb 2016, Stephen Boyd wrote:
>
> > Convert this driver to use clkdev_create() instead of
> > clk_register_clkdevs(). The latter API is only used by this driver,
> > although this driver only allocates one clk to add anyway.
> > Furthermore, this driver allocates the clk_lookup structure with
> > devm, but clkdev_drop() will free that structure when passed,
> > leading to a double free when this driver is removed. Clean it
> > all up and pave the way for the removal of clk_register_clkdevs().
> >
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > drivers/mfd/intel_quark_i2c_gpio.c | 26 +++++++++-----------------
> > 1 file changed, 9 insertions(+), 17 deletions(-)
>
> I never much liked this code [0]
>
> Glad for it to be simplified.
>
> Applied, thanks.
>
Can you please ack the patch instead? I'd like to take it through
the clk tree so that I can remove clk_register_clkdevs() as well.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-10 18:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 1:45 [PATCH 00/14] clk_hw based clkdev/DT providers Stephen Boyd
2016-02-09 1:45 ` [PATCH 01/14] mfd: intel_quark_i2c_gpio: Use clkdev_create() Stephen Boyd
2016-02-10 16:23 ` Lee Jones
2016-02-10 18:35 ` Stephen Boyd [this message]
2016-02-11 9:09 ` Lee Jones
2016-02-11 11:08 ` Lee Jones
2016-02-15 15:14 ` Andy Shevchenko
2016-02-15 22:13 ` Michael Turquette
2016-02-09 1:45 ` [PATCH 02/14] clkdev: Remove clk_register_clkdevs() Stephen Boyd
2016-02-15 15:16 ` Andy Shevchenko
2016-02-15 22:12 ` Michael Turquette
2016-02-09 1:45 ` [PATCH 03/14] clk: Add {devm_}clk_hw_{register,unregister}() APIs Stephen Boyd
2016-02-15 22:13 ` [PATCH 03/14] clk: Add {devm_}clk_hw_{register, unregister}() APIs Michael Turquette
2016-02-09 1:45 ` [PATCH 04/14] clk: Add clk_hw OF clk providers Stephen Boyd
2016-02-09 3:31 ` kbuild test robot
2016-02-09 1:45 ` [PATCH 05/14] clkdev: Add clk_hw based registration APIs Stephen Boyd
2016-02-09 1:45 ` [PATCH 06/14] clk: divider: Add hw " Stephen Boyd
2016-02-09 1:45 ` [PATCH 07/14] clk: gate: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 08/14] clk: mux: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 09/14] clk: fixed-factor: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 10/14] clk: fractional-divider: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 11/14] clk: composite: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 12/14] clk: gpio: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 13/14] clk: fixed-rate: " Stephen Boyd
2016-02-09 1:45 ` [PATCH 14/14] clk: qcom: Migrate to clk_hw based registration and OF APIs Stephen Boyd
2016-02-09 5:30 ` kbuild test robot
2016-02-09 8:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210183504.GG30978@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).