From: k@japko.eu (Krzysztof Adamski)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set
Date: Thu, 11 Feb 2016 14:20:54 +0100 [thread overview]
Message-ID: <20160211132054.GC19622@box2.japko.eu> (raw)
In-Reply-To: <CACRpkdbc0SfKiCGwUGA2fAPPsUhGv=qGV607Lht6ByYKKgTHjA@mail.gmail.com>
On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote:
>On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k@japko.eu> wrote:
>
>> sunxi_pmx_set accepts pin number and then calculates offset by
>> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
>> gets offset so we have to convert it to pin number so we won't get
>> negative value in sunxi_pmx_set.
>>
>> This was only used on A10 so far, where there is only one GPIO chip with
>> pin_base set to 0 so it didn't matter. However H3 also requires this
>> workaround but have two pinmux sections, triggering problem for PL port.
>>
>> Signed-off-by: Krzysztof Adamski <k@japko.eu>
>
>Waiting for Maxime to review this. I guess this patch can be merged
>independently of the other patches?
Yes it can but it won't have any effect, as stated in the commit
message, since other SoCs either don't use this flag or have only one
port so theri pin_base=0.
Best regards,
Krzysztof Adamski
next prev parent reply other threads:[~2016-02-11 13:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 21:21 [PATCH v2 0/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
2016-02-02 21:21 ` [PATCH v2 1/5] clk: sunxi: Add apb0 gates for H3 Krzysztof Adamski
2016-02-03 7:04 ` Chen-Yu Tsai
2016-02-02 21:21 ` [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets Krzysztof Adamski
2016-02-03 12:35 ` Maxime Ripard
2016-02-03 22:21 ` Krzysztof Adamski
2016-02-03 23:44 ` Krzysztof Adamski
2016-02-02 21:21 ` [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
2016-02-03 12:36 ` Maxime Ripard
2016-02-11 13:21 ` Linus Walleij
2016-02-15 8:08 ` [linux-sunxi] " Krzysztof Adamski
2016-02-15 9:17 ` Linus Walleij
2016-02-18 15:03 ` [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Krzysztof Adamski
2016-02-18 17:07 ` Chen-Yu Tsai
2016-02-18 19:42 ` [linux-sunxi] " Krzysztof Adamski
2016-02-18 19:49 ` [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation Krzysztof Adamski
2016-02-21 18:29 ` Chen-Yu Tsai
2016-02-25 9:27 ` Linus Walleij
2016-02-02 21:21 ` [PATCH v2 4/5] ARM: dts: sun8i-h3: Add R_PIO controller node to the dtsi Krzysztof Adamski
2016-02-02 22:19 ` [linux-sunxi] " Julian Calaby
2016-02-02 21:21 ` [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set Krzysztof Adamski
2016-02-03 7:02 ` Chen-Yu Tsai
2016-02-11 13:17 ` Linus Walleij
2016-02-11 13:20 ` Krzysztof Adamski [this message]
2016-02-11 13:50 ` [linux-sunxi] " Linus Walleij
2016-02-11 13:21 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211132054.GC19622@box2.japko.eu \
--to=k@japko.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).