From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX
Date: Thu, 11 Feb 2016 18:00:32 +0000 [thread overview]
Message-ID: <20160211180032.GY10826@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAGXu5jLDK8eVO2kUD1cB3TArL8k8pF=igc3O04Fa40QgQ2pwNw@mail.gmail.com>
On Fri, Jan 22, 2016 at 01:19:03PM -0800, Kees Cook wrote:
> On Tue, Dec 8, 2015 at 10:38 AM, Kees Cook <keescook@chromium.org> wrote:
> > On Mon, Dec 7, 2015 at 11:47 PM, Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> >> On 7 December 2015 at 23:35, Kees Cook <keescook@chromium.org> wrote:
> >>> /*
> >>> + * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
> >>> + * be the first section-aligned location after __start_rodata. Otherwise,
> >>> + * it will be equal to __start_rodata.
> >>> + */
> >>> +__start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
...
I'm afraid this causes build errors on two configurations:
./arch/arm/kernel/vmlinux.lds:701: undefined symbol `SECTION_SHIFT' referenced in expression
which I think is down to the new __start_rodata_section_aligned line.
Olof's builder errored out with this for both allnoconfig and
lpc18xx_defconfig builds. Both probably due to CONFIG_MMU being
unset, and hence no definition for SECTION_SHIFT.
I think you need to make this conditional on CONFIG_MMU.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently@9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-02-11 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 22:35 [PATCH v2] ARM: mm: mark section-aligned portion of rodata NX Kees Cook
2015-12-08 7:47 ` Ard Biesheuvel
2015-12-08 18:38 ` Kees Cook
2016-01-22 21:19 ` Kees Cook
2016-01-22 22:08 ` Ard Biesheuvel
2016-02-11 18:00 ` Russell King - ARM Linux [this message]
2016-02-12 9:45 ` Arnd Bergmann
2016-02-15 8:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211180032.GY10826@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).