linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: david.brown@linaro.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [kernel-hardening] [PATCH] arm64: vdso: Mark vDSO code as read-only
Date: Fri, 12 Feb 2016 17:31:47 -0700	[thread overview]
Message-ID: <20160213003147.GA12074@davidb.org> (raw)
In-Reply-To: <CAKv+Gu8ArOYqxDGKb=Tv3NsiB2qWWCdD_zMx55m6+hEwLJR4CA@mail.gmail.com>

On Thu, Feb 11, 2016 at 03:19:20PM +0100, Ard Biesheuvel wrote:

>> diff --git a/arch/arm64/kernel/vdso/vdso.S b/arch/arm64/kernel/vdso/vdso.S
>> index 60c1db5..db7c0f2 100644
>> --- a/arch/arm64/kernel/vdso/vdso.S
>> +++ b/arch/arm64/kernel/vdso/vdso.S
>> @@ -24,6 +24,7 @@
>>         __PAGE_ALIGNED_DATA
>
>^^ You can get rid of this now as well

Can we?  The page is getting mapped to userspace, and if we didn't
page align it, we could leak kernel read-only data to every userspace
process.

David

  reply	other threads:[~2016-02-13  0:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 21:52 [PATCH] arm64: vdso: Mark vDSO code as read-only David Brown
2016-02-11 13:47 ` Will Deacon
2016-02-11 14:19 ` [kernel-hardening] " Ard Biesheuvel
2016-02-13  0:31   ` David Brown [this message]
2016-02-13  9:00     ` Ard Biesheuvel
2016-02-16 18:22 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160213003147.GA12074@davidb.org \
    --to=david.brown@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).