From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles'
Date: Mon, 15 Feb 2016 11:10:14 +0100 [thread overview]
Message-ID: <20160215101014.GG12289@pengutronix.de> (raw)
In-Reply-To: <20160215100415.GD10826@n2100.arm.linux.org.uk>
Hello Russell,
On Mon, Feb 15, 2016 at 10:04:15AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 15, 2016 at 10:14:06AM +0100, Uwe Kleine-K?nig wrote:
> > On Mon, Feb 15, 2016 at 08:58:18AM +0000, Russell King - ARM Linux wrote:
> > > On Mon, Feb 15, 2016 at 09:17:50AM +0100, Uwe Kleine-K?nig wrote:
> > > > On Sun, Feb 14, 2016 at 08:07:55PM +0000, Russell King - ARM Linux wrote:
> > > > > On Sun, Feb 14, 2016 at 08:55:01PM +0100, Uwe Kleine-K?nig wrote:
> > > > > > So the unexpected abnormality here is that even though this device is
> > > > > > instantiated by dt, the driver doesn't provide any compatibles.
> > > > > > Either my expectation is wrong, then 67d02a1bbb33455 should be reverted
> > > > >
> > > > > Your expectation is wrong. AMBA primecell devices have hardware IDs
> > > > > and are matched to their drivers by those IDs. Just like PCI.
> > > >
> > > > pci devices don't appear in dt, do they? I don't see the connection
> > > > between amba devices and platform devices, see my other mail in this
> > > > thread for some more details.
> > >
> > > They both have hardware IDs, and they are both matched via those hardware
> > > IDs.
> >
> > I changed platform_match which is about matching by dt compatible, acpi
> > and/or device name. I don't see how this can affect an amba device given
> > they match to a driver by a hardware id.
> >
> > > Your change has introduced a regression and is therefore wrong.
> >
> > I'd like to understand though why and how my commit is wrong to be able
> > to fix it instead of getting it reverted.
>
> I don't have the commit, and I haven't seen the patch so I can't
> comment further, sorry.
It's in -next. For a quick look:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=67d02a1bbb33455
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-02-15 10:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160214165010.GA3189@roeck-us.net>
2016-02-14 19:55 ` arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles' Uwe Kleine-König
2016-02-14 20:07 ` Russell King - ARM Linux
2016-02-15 8:17 ` Uwe Kleine-König
2016-02-15 8:58 ` Russell King - ARM Linux
2016-02-15 9:14 ` Uwe Kleine-König
2016-02-15 10:04 ` Russell King - ARM Linux
2016-02-15 10:10 ` Uwe Kleine-König [this message]
2016-02-15 10:13 ` Russell King - ARM Linux
2016-02-14 21:08 ` Guenter Roeck
2016-02-15 7:48 ` Uwe Kleine-König
2016-02-15 10:59 ` Uwe Kleine-König
2016-02-15 13:11 ` Robin Murphy
2016-02-15 14:43 ` Russell King - ARM Linux
2016-02-15 16:27 ` Uwe Kleine-König
2016-02-15 16:49 ` Greg Kroah-Hartman
2016-02-15 17:12 ` Uwe Kleine-König
2016-02-15 21:03 ` Greg Kroah-Hartman
2016-02-15 15:41 ` Guenter Roeck
2016-02-15 16:12 ` Russell King - ARM Linux
2016-02-15 17:00 ` Uwe Kleine-König
2016-02-15 18:12 ` Guenter Roeck
2016-02-15 18:39 ` Sudeep Holla
2016-02-15 17:41 ` Sudeep Holla
2016-02-15 18:03 ` Russell King - ARM Linux
2016-02-15 18:15 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215101014.GG12289@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).