public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm64/mm: Add .rodata to kernel virtual memory boot notice
Date: Wed, 17 Feb 2016 17:04:10 +0000	[thread overview]
Message-ID: <20160217170409.GG32647@leverpostej> (raw)
In-Reply-To: <1455727274-16328-3-git-send-email-jeremy.linton@arm.com>

On Wed, Feb 17, 2016 at 10:41:14AM -0600, Jeremy Linton wrote:
> Now that .rodata has differing permissions from .text
> display it in the mem_init banner as a seperate memory range.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  arch/arm64/mm/init.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

This looks fine, but I think it would be better to have this folded into
the prior patch.

Mark.

> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 5dd0831..41be7db 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -325,6 +325,7 @@ void __init mem_init(void)
>  		  "    memory  : 0x%16lx - 0x%16lx   (%6ld MB)\n"
>  		  "      .init : 0x%p" " - 0x%p" "   (%6ld KB)\n"
>  		  "      .text : 0x%p" " - 0x%p" "   (%6ld KB)\n"
> +		  "    .rodata : 0x%p" " - 0x%p" "   (%6ld KB)\n"
>  		  "      .data : 0x%p" " - 0x%p" "   (%6ld KB)\n",
>  #ifdef CONFIG_KASAN
>  		  MLG(KASAN_SHADOW_START, KASAN_SHADOW_END),
> @@ -341,7 +342,8 @@ void __init mem_init(void)
>  		  MLM(MODULES_VADDR, MODULES_END),
>  		  MLM(PAGE_OFFSET, (unsigned long)high_memory),
>  		  MLK_ROUNDUP(__init_begin, __init_end),
> -		  MLK_ROUNDUP(_text, _etext),
> +		  MLK_ROUNDUP(_text, __start_rodata),
> +		  MLK_ROUNDUP(__start_rodata, _etext),
>  		  MLK_ROUNDUP(_sdata, _edata));
>  
>  #undef MLK
> -- 
> 2.4.3
> 

      reply	other threads:[~2016-02-17 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 16:41 [PATCH v2 0/2] arm64: mm: Mark .rodata as RO Jeremy Linton
2016-02-17 16:41 ` [PATCH v2 1/2] " Jeremy Linton
2016-02-17 16:46   ` Ard Biesheuvel
2016-02-17 16:54     ` Jeremy Linton
2016-02-17 16:55       ` Ard Biesheuvel
2016-02-17 17:02         ` Mark Rutland
2016-02-17 16:41 ` [PATCH v2 2/2] arm64/mm: Add .rodata to kernel virtual memory boot notice Jeremy Linton
2016-02-17 17:04   ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217170409.GG32647@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox