From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm64: Broadcom Vulcan support
Date: Wed, 17 Feb 2016 17:16:17 +0000 [thread overview]
Message-ID: <20160217171616.GH32647@leverpostej> (raw)
In-Reply-To: <1455389195-31870-2-git-send-email-jchandra@broadcom.com>
Hi,
On Sun, Feb 14, 2016 at 12:16:32AM +0530, Jayachandran C wrote:
> From: Zi Shen Lim <zlim@broadcom.com>
> + compatible = "brcm,vulcan-eval", "brcm,vulcan";
You use "brcm,vulcan" as the compatible string for both the platform and
the CPU nodes. You need different strings.
> +
> + memory {
> + device_type = "memory";
> + reg = <0x00000000 0x80000000 0x0 0x80000000>, /* 2G @ 2G */
> + <0x00000008 0x80000000 0x0 0x80000000>; /* 2G @ 34G */
> + };
> +/memreserve/ 0x80000000 0x00010000;
What is this for?
> +
> +/ {
> + model = "Broadcom Vulcan";
> + compatible = "brcm,vulcan";
As above, it doesn't make sense to have the same compatible string for
both the platform as a whole and the CPU.
> + device_type = "cpu";
> + compatible = "brcm,vulcan", "arm,armv8";
> + reg = <0x0 0x0>;
> + enable-method = "psci";
> + };
Thanks,
Mark.
next prev parent reply other threads:[~2016-02-17 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 18:46 [PATCH 0/4] Support for Broadcom Vulcan ARM64 processor Jayachandran C
2016-02-13 18:46 ` [PATCH 1/4] arm64: Broadcom Vulcan support Jayachandran C
2016-02-17 1:22 ` Florian Fainelli
2016-02-17 17:16 ` Mark Rutland [this message]
2016-02-19 6:58 ` Jayachandran Chandrashekaran Nair
2016-02-18 18:15 ` [1/4] " Ray Jui
2016-02-19 19:24 ` Florian Fainelli
2016-02-13 18:46 ` [PATCH 2/4] dt-bindings: Add documentation for Broadcom Vulcan Jayachandran C
2016-02-17 17:17 ` Mark Rutland
2016-02-13 18:46 ` [PATCH 3/4] arm64: defconfig: Add Broadcom Vulcan to defconfig Jayachandran C
2016-02-13 18:46 ` [PATCH 4/4] arm64: cputype info for Broadcom Vulcan Jayachandran C
2016-02-15 10:12 ` Will Deacon
2016-02-17 1:16 ` Florian Fainelli
2016-02-17 17:26 ` Catalin Marinas
2016-02-17 7:32 ` Zi Shen Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217171616.GH32647@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox