linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt-bindings: clock: adpll: Add binding documentation for TI adpll
Date: Wed, 17 Feb 2016 09:28:36 -0800	[thread overview]
Message-ID: <20160217172836.GA21202@atomide.com> (raw)
In-Reply-To: <20160217010440.2278.62327@quark.deferred.io>

* Michael Turquette <mturquette@baylibre.com> [160216 17:17]:
> Quoting Tony Lindgren (2016-02-12 13:20:08)
> > +Required properties:
> > +- compatible : shall be one of "ti,dm814-adpll-s-clock" or
> > +  "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL
> > +- #clock-cells : from common clock binding; shall be set to 0.
> 
> Thanks for the patch.
> 
> clock-cells = 1 in both of the examples below (which looks right).

Oops thanks, will update to 1.

> > +- clocks : link phandles of parent clocks clkinp and clkinpulow, note
> > +  that the adpll-s-clock also has an optional clkinphif
> > +- reg : address and length of the register set for controlling the ADPLL.
> > +
> > +Examples:
> > +       adpll_mpu_ck: adpll at 40 {
> > +               #clock-cells = <1>;
> > +               compatible = "ti,dm814-adpll-s-clock";
> > +               reg = <0x40 0x40>;
> > +               clocks = <&devosc_ck &devosc_ck &devosc_ck>;
> > +               clock-names = "clkinp", "clkinpulow", "clkinphif";
> > +               clock-indices = <0>, <1>, <2>, <3>;
> 
> Why is clock-indices necessary?

Hmm yeah I don't think it's needed, so will drop.

Regards,

Tony

  reply	other threads:[~2016-02-17 17:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 21:20 [PATCHv5 0/2] Clock driver for dm814x and dra62x ADPLL Tony Lindgren
2016-02-12 21:20 ` [PATCH 1/2] dt-bindings: clock: adpll: Add binding documentation for TI adpll Tony Lindgren
2016-02-17  1:04   ` Michael Turquette
2016-02-17 17:28     ` Tony Lindgren [this message]
2016-02-12 21:20 ` [PATCH 2/2] clk: ti: Add support for dm814x ADPLL Tony Lindgren
2016-02-17  1:19   ` Michael Turquette
2016-02-17 17:39     ` Tony Lindgren
2016-02-17 20:52       ` Michael Turquette
2016-02-17 21:20         ` Tony Lindgren
2016-02-17 23:02           ` Michael Turquette
2016-02-23 13:47             ` Matthijs van Duin
2016-02-26 17:35               ` Tony Lindgren
2016-02-29 22:19                 ` Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217172836.GA21202@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).