From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] arm64/perf: Rename Cortex A57 events
Date: Thu, 18 Feb 2016 11:24:29 +0000 [thread overview]
Message-ID: <20160218112429.GC8011@arm.com> (raw)
In-Reply-To: <20160218091307.GA4566@hardcore>
On Thu, Feb 18, 2016 at 10:13:07AM +0100, Jan Glauber wrote:
> On Mon, Feb 15, 2016 at 08:06:13PM +0000, Will Deacon wrote:
> > On Mon, Feb 15, 2016 at 07:40:37PM +0000, Will Deacon wrote:
> > > On Wed, Feb 03, 2016 at 06:11:56PM +0100, Jan Glauber wrote:
> > > > The implemented Cortex A57 events are not A57 specific.
> > > > They are recommended by ARM and can be found on other
> > > > ARMv8 SOCs like Cavium ThunderX too. Therefore move
> > > > these events to the common PMUv3 table.
> > >
> > > I can't find anything in the architecture that suggests these event
> > > numbers are necessarily portable between implementations. Am I missing
> > > something?
> >
> > Aha, I just noticed appendix K3.1 (silly me for missing it...).
> >
> > Lemme check whether or not that mandates that those encodings can't be
> > used for wildly different things.
>
> To me it looks like we would just have duplicated code without the patch,
> and at least the event types (e.g. L1D_CACHE_RD) should be identical
> across implementations.
>
> But I don't care too much, so please tell me if should drop the patch or
> keep it.
Tell you what then -- how about we simply rename those to ARMV8_IMPDEF_*
instead of ARMV8_A57_*? That way, we can easily identify them as distinct
from the architected events if we need to in future.
Will
next prev parent reply other threads:[~2016-02-18 11:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 17:11 [PATCH v3 0/5] Cavium ThunderX PMU support Jan Glauber
2016-02-03 17:11 ` [PATCH v3 1/5] arm64/perf: Rename Cortex A57 events Jan Glauber
2016-02-15 19:40 ` Will Deacon
2016-02-15 20:06 ` Will Deacon
2016-02-18 9:13 ` Jan Glauber
2016-02-18 11:24 ` Will Deacon [this message]
2016-02-18 13:45 ` Jan Glauber
2016-02-03 17:11 ` [PATCH v3 2/5] arm64/perf: Add Cavium ThunderX PMU support Jan Glauber
2016-02-03 17:11 ` [PATCH v3 3/5] arm64: dts: Add Cavium ThunderX specific PMU Jan Glauber
2016-02-03 17:11 ` [PATCH v3 4/5] arm64/perf: Enable PMCR long cycle counter bit Jan Glauber
2016-02-15 19:55 ` Will Deacon
2016-02-16 8:04 ` Jan Glauber
2016-02-03 17:12 ` [PATCH v3 5/5] arm64/perf: Extend event mask for ARMv8.1 Jan Glauber
2016-02-15 20:04 ` Will Deacon
2016-02-16 8:00 ` Jan Glauber
2016-02-16 15:12 ` Will Deacon
2016-02-17 10:47 ` Jan Glauber
2016-02-11 13:28 ` [PATCH v3 0/5] Cavium ThunderX PMU support Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218112429.GC8011@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).