From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi
Date: Thu, 18 Feb 2016 13:57:51 +0000 [thread overview]
Message-ID: <20160218135751.GE7129@sirena.org.uk> (raw)
In-Reply-To: <56C5959D.3030806@rock-chips.com>
On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:
> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
> the compatible like:
> - compatible: should be one of the followings
> - "rockchip,rk3066-i2s": for rk3066
> - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
> - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
> - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
> and the driver only has
> static const struct of_device_id rockchip_i2s_match[] = {
> { .compatible = "rockchip,rk3066-i2s", },
> {},
> };
> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
> keep different rules ?
No, that's just something that got missed in review and which should be
fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160218/6cb04dc6/attachment.sig>
next prev parent reply other threads:[~2016-02-18 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 2:36 [PATCH v2 0/4] Add core dtsi for rk3399 from Rockchip jianqun.xu
2016-02-18 2:36 ` [PATCH v2 1/4] clk: rockchip: add dt-binding header for rk3399 jianqun.xu
2016-02-18 2:36 ` [PATCH v2 2/4] spi: rockchip: add bindings for rk3399 spi jianqun.xu
2016-02-18 9:41 ` Mark Brown
2016-02-18 9:47 ` [PATCH v2.1 " Heiko Stuebner
2016-02-18 9:57 ` Jianqun Xu
2016-02-18 13:57 ` Mark Brown [this message]
2016-02-19 2:44 ` Jianqun Xu
2016-02-18 2:36 ` [PATCH v2 3/4] dt-bindings: add documentation of rk3399 clock controller jianqun.xu
2016-02-18 2:36 ` [PATCH v2 4/4] ARM64: dts: rockchip: add core dtsi file for rk3399 jianqun.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218135751.GE7129@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).