From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/1] USB: core: let USB device know device node
Date: Thu, 18 Feb 2016 08:38:08 -0600 [thread overview]
Message-ID: <20160218143808.GY9654@rob-hp-laptop> (raw)
In-Reply-To: <1455612172-2081-1-git-send-email-peter.chen@nxp.com>
On Tue, Feb 16, 2016 at 04:42:52PM +0800, Peter Chen wrote:
> From: Peter Chen <peter.chen@freescale.com>
>
> Although most of USB devices are hot-plug's, there are still some devices
> are hard wired on the board, eg, for HSIC and SSIC interface USB devices.
> If these kinds of USB devices are multiple functions, and they can supply
> other interfaces like i2c, gpios for other devices, we may need to
> describe these at device tree.
>
> In this commit, it uses "reg" in dts as physical port number to match
> the phyiscal port number decided by USB core, if they are the same,
> then the device node is for the device we are creating for USB core.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
> Changes for v5:
> - Refine the code how to get the device node at usb_alloc_dev according
> to Alan's comment.
> - Point out "usbVID,PID" is the recommented compatible, and others
> compatibles at binding doc could also be used.
>
> Changes for v4:
> - The range of "reg" should be 1-31, changing device node address
> style as in lower case hexadecimal with leading zeroes suppressed
> [binding doc, usb-device.txt]
> - Improve the example at binding doc, it describes node from the top
> (the controller)
> - Delete the struct of_node * within struct usb_device
> - Using usb_hcd_find_raw_port_number to get raw port number under root
> hub port
>
> Changes for v3:
> - typo: s/descirbe/describe/
>
> Changes for v2:
> - Fix build error reported by kbuild robot, lack of "static" for
> inline usb_of_get_child_node
> - Fix typo, "devcie_node" -> "device_node"
> - Add kernel-doc for of_node at struct usb_device
>
> Changes from RFC:
> - Fix the error address for binding doc, and add compatible for binding doc
> - Change get child node API from "usb_of_find_node" to
> "usb_of_get_child_node"
> - Delete unecessary header files
> - One typo
>
> .../devicetree/bindings/usb/usb-device.txt | 26 ++++++++++++
Looks good to me. Thanks for driving this to completion.
Acked-by: Rob Herring <robh@kernel.org>
> drivers/usb/core/Makefile | 2 +-
> drivers/usb/core/of.c | 47 ++++++++++++++++++++++
> drivers/usb/core/usb.c | 10 +++++
> include/linux/usb/of.h | 7 ++++
> 5 files changed, 91 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/usb/usb-device.txt
> create mode 100644 drivers/usb/core/of.c
>
next prev parent reply other threads:[~2016-02-18 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 8:42 [PATCH v5 1/1] USB: core: let USB device know device node Peter Chen
2016-02-18 14:38 ` Rob Herring [this message]
2016-02-18 18:46 ` Alan Stern
2016-02-19 8:51 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218143808.GY9654@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox