From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered
Date: Fri, 19 Feb 2016 13:20:14 +0900 [thread overview]
Message-ID: <20160219042014.GB27936@samsunx.samsung> (raw)
In-Reply-To: <1455819551-4666-4-git-send-email-javier@osg.samsung.com>
Hi Javier,
Just a question...
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index f4f36bba7be9..f3ce94ec73b5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1318,6 +1318,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> return ret;
> }
> } else {
> + if (PTR_ERR(data->regulator) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
shouldn't we return also in case of -ENOMEM? -ENOMEM is a Kernel
failure, not depending on the regulator itself.
Andi
> dev_info(&pdev->dev, "Regulator node (vtmu) not found\n");
> }
next prev parent reply other threads:[~2016-02-19 4:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 18:19 [PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling Javier Martinez Canillas
2016-02-18 18:19 ` [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding Javier Martinez Canillas
2016-02-19 0:26 ` Krzysztof Kozlowski
2016-02-23 20:26 ` Rob Herring
2016-03-08 21:07 ` Eduardo Valentin
2016-03-08 21:30 ` Javier Martinez Canillas
2016-03-08 21:51 ` Eduardo Valentin
2016-02-18 18:19 ` [PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu Javier Martinez Canillas
2016-02-19 0:33 ` Krzysztof Kozlowski
2016-02-18 18:19 ` [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered Javier Martinez Canillas
2016-02-19 0:37 ` Krzysztof Kozlowski
2016-02-19 4:20 ` Andi Shyti [this message]
2016-02-19 4:25 ` Krzysztof Kozlowski
2016-02-19 4:29 ` [PATCH 0/3] thermal: exynos: Fixes for vtmu-supply regulator handling Andi Shyti
2016-03-08 13:30 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219042014.GB27936@samsunx.samsung \
--to=andi.shyti@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox