linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Allow MULTIPLATFORM to select XIP
Date: Fri, 19 Feb 2016 16:47:42 +0000	[thread overview]
Message-ID: <20160219164742.GZ19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <64215923.Y25jP5YYZ2@wuerfel>

On Fri, Feb 19, 2016 at 04:59:43PM +0100, Arnd Bergmann wrote:
> On Friday 19 February 2016 15:36:23 Chris Brandt wrote:
> > On 19 Feb 2016, Arnd Bergmann wrote:
> > 
> > > For PHYS_OFFSET, parsing the DT doesn't help at all because we only
> > > need it for XIP_KERNEL (more or less at least) which cannot patch
> > > the kernel image at boot time, so knowing that the address is wrong
> > > also doesn't help you.
> > > 
> > > 	Arnd
> > 
> > OK, at first I was thinking that PHYS_OFFSET was only used early in boot as a pointer to valid RAM before the DT was read (in head.S and head-nommu.S). Hence, you could pass in the pointer in via another CPU register like the DT pointer is passed in.
> > 
> > But, now I see that PHYS_OFFSET is used all over the place as a hard coded #define, hence your comment "which cannot patch the kernel image at boot time"
> > 
> > So, I retract my thought...it has to be configured at build-time (unless of course you turn it into a global variable everywhere...which might be an even bigger mess)
> > 
> 
> BTW, I've tried removing the patching in CONFIG_PHYS_VIRT and replaced it
> with references to __pv_phys_pfn_offset, which surprisingly only grew
> .text from 4901692 to 4904300 bytes, so the size overhead of doing this
> would be close to zero.

The next job is to perf the resulting kernel - because you will have
the additional overhead of loading the offset.  Size is not everything,
contary to popular beliefs.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  parent reply	other threads:[~2016-02-19 16:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 17:25 [PATCH] ARM: Allow MULTIPLATFORM to select XIP Chris Brandt
2016-02-18 17:48 ` Nicolas Pitre
2016-02-18 18:18   ` Chris Brandt
2016-02-18 18:31     ` Nicolas Pitre
2016-02-18 19:42       ` Chris Brandt
2016-02-18 22:33         ` Russell King - ARM Linux
2016-02-19  3:39           ` Chris Brandt
2016-02-19 11:11             ` Arnd Bergmann
2016-02-19 13:49               ` Chris Brandt
2016-02-19 14:21                 ` Arnd Bergmann
2016-02-19 14:46                   ` Chris Brandt
2016-02-19 15:06                     ` Arnd Bergmann
2016-02-19 15:36                       ` Chris Brandt
2016-02-19 15:59                         ` Arnd Bergmann
2016-02-19 16:28                           ` Chris Brandt
2016-02-19 16:39                             ` Arnd Bergmann
2016-02-19 16:47                           ` Russell King - ARM Linux [this message]
2016-02-23 19:15 ` [PATCH v2] " Chris Brandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219164742.GZ19428@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).