* [PATCH] netcp: fix typo in netcp_setup_tc
@ 2016-02-22 20:50 Arnd Bergmann
2016-02-22 20:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-22 20:50 UTC (permalink / raw)
To: linux-arm-kernel
A change to the prototype of netcp_setup_tc() missed a '*'
character, which broke compilation of hte netcp driver:
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_tc':
drivers/net/ethernet/ti/netcp_core.c:1839:31: error: invalid type argument of '->' (have 'struct tc_to_netdev')
drivers/net/ethernet/ti/netcp_core.c:1872:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand")
---
drivers/net/ethernet/ti/netcp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index 132caebb401a..e74e68eabd5f 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -1829,7 +1829,7 @@ static u16 netcp_select_queue(struct net_device *dev, struct sk_buff *skb,
}
static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto,
- struct tc_to_netdev tc)
+ struct tc_to_netdev *tc)
{
int i;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] netcp: fix typo in netcp_setup_tc
2016-02-22 20:50 [PATCH] netcp: fix typo in netcp_setup_tc Arnd Bergmann
@ 2016-02-22 20:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-02-22 20:52 UTC (permalink / raw)
To: linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 22 Feb 2016 21:50:39 +0100
> A change to the prototype of netcp_setup_tc() missed a '*'
> character, which broke compilation of hte netcp driver:
>
> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_tc':
> drivers/net/ethernet/ti/netcp_core.c:1839:31: error: invalid type argument of '->' (have 'struct tc_to_netdev')
> drivers/net/ethernet/ti/netcp_core.c:1872:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand")
Should be fixed in my net-next tree already.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-22 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 20:50 [PATCH] netcp: fix typo in netcp_setup_tc Arnd Bergmann
2016-02-22 20:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).