From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: remove redundant preempt.h
Date: Mon, 22 Feb 2016 17:03:46 +0000 [thread overview]
Message-ID: <20160222170346.GN3435@leverpostej> (raw)
In-Reply-To: <20160222095205.GA31168@arm.com>
On Mon, Feb 22, 2016 at 09:52:05AM +0000, Will Deacon wrote:
> On Fri, Feb 19, 2016 at 04:07:02PM -0800, Shi, Yang wrote:
> > Any comment on this one?
>
> I don't really see the point in it, to be honest. Relying on implicit
> #includes is usually a bad idea,
FWIW, in this case we aren't relying on implicit includes. That's when
you explicitly use something but haven't included the relevant header
directly.
For everything we explicitly use, we have included the relevant headers.
Anything that uses preempt.h implicitly should've pulled in preempt.h
via its headers.
> there are other files in the kernel including both of these headers
> and there's not actually a problem to fix as far as I can tell.
Up to you.
The patch does appear correct in that the include is redundant, but its
presence is admittedly not harmful.
Mark.
>
> Will
>
> > On 2/12/2016 9:56 AM, Yang Shi wrote:
> > >preempt.h has been included by sched.h, so it is not necessary to include
> > >both, just keep sched.h.
> > >
> > >Signed-off-by: Yang Shi <yang.shi@linaro.org>
> > >---
> > >Happened to find this when checking preempt.h include for another patch review.
> > >Build test is passed with and without CONFIG_PREEMPT enabled.
> > >
> > > arch/arm64/kernel/cpuinfo.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > >diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> > >index 212ae63..e2b37ff 100644
> > >--- a/arch/arm64/kernel/cpuinfo.c
> > >+++ b/arch/arm64/kernel/cpuinfo.c
> > >@@ -25,7 +25,6 @@
> > > #include <linux/init.h>
> > > #include <linux/kernel.h>
> > > #include <linux/personality.h>
> > >-#include <linux/preempt.h>
> > > #include <linux/printk.h>
> > > #include <linux/seq_file.h>
> > > #include <linux/sched.h>
> > >
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2016-02-22 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:56 [PATCH] arm64: remove redundant preempt.h Yang Shi
2016-02-20 0:07 ` Shi, Yang
2016-02-22 9:52 ` Will Deacon
2016-02-22 17:03 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222170346.GN3435@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox