From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: qoriq depends on thermal
Date: Fri, 26 Feb 2016 20:50:15 +0530 [thread overview]
Message-ID: <20160226152015.GA21797@vireshk-i7> (raw)
In-Reply-To: <1456489361-469413-1-git-send-email-arnd@arndb.de>
On 26-02-16, 13:22, Arnd Bergmann wrote:
> The thermal subsystem can be a loadable module, so the qoriq driver has to be
> a module in that case as well in order to call of_cpufreq_cooling_register:
>
> drivers/built-in.o: In function `qoriq_cpufreq_ready':
> text+0x1f4548): undefined reference to `of_cpufreq_cooling_register'
>
> This adds a dependency that clarifies how we can either build the driver
> when the cpu_thermal support is completely disabled, or how it depends
> on the thermal support to enforce the qoriq driver to be a module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8ae1702a0df5 ("cpufreq: qoriq: Register cooling device based on device tree")
> ---
> drivers/cpufreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> My patch is from Dec 22, and I had marked it as submitted, but can't
> find the email now, so maybe I forgot to send it out back then.
>
> The problem still exists in linux-next, please apply the patch
> for 4.6.
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index dcb972a38fbc..ca05037dd565 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -297,6 +297,7 @@ endif
> config QORIQ_CPUFREQ
> tristate "CPU frequency scaling driver for Freescale QorIQ SoCs"
> depends on OF && COMMON_CLK && (PPC_E500MC || ARM)
> + depends on !CPU_THERMAL || THERMAL=y
> select CLK_QORIQ
> help
> This adds the CPUFreq driver support for Freescale QorIQ SoCs
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2016-02-26 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 12:22 [PATCH] cpufreq: qoriq depends on thermal Arnd Bergmann
2016-02-26 15:20 ` Viresh Kumar [this message]
2016-02-26 23:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226152015.GA21797@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).