* [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries [not found] ` <20160225220224.GA9986@hector.attlocal.net> @ 2016-03-01 17:10 ` Paul Walmsley 2016-03-01 17:27 ` Bjorn Andersson 0 siblings, 1 reply; 2+ messages in thread From: Paul Walmsley @ 2016-03-01 17:10 UTC (permalink / raw) To: linux-arm-kernel On Thu, 25 Feb 2016, Andy Gross wrote: > On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote: > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > drivers/soc/qcom/smp2p.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > index f1eed7f9dd67..61df598444e6 100644 > > --- a/drivers/soc/qcom/smp2p.c > > +++ b/drivers/soc/qcom/smp2p.c > > @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p) > > return PTR_ERR(out); > > } > > > > - memset(out, 0, sizeof(*out)); > > + memset_io(out, 0, sizeof(*out)); > > out->magic = SMP2P_MAGIC; > > out->local_pid = smp2p->local_pid; > > out->remote_pid = smp2p->remote_pid; > > Good catch. I'll add this fix for the pull. Folks, is qmem_smem_get() intended to return pointers to device-mapped memory, as implied by this change? If so, shouldn't the return type of qmem_smem_get() et al. be void __iomem * rather than void *? - Paul ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries 2016-03-01 17:10 ` [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries Paul Walmsley @ 2016-03-01 17:27 ` Bjorn Andersson 0 siblings, 0 replies; 2+ messages in thread From: Bjorn Andersson @ 2016-03-01 17:27 UTC (permalink / raw) To: linux-arm-kernel On Tue 01 Mar 09:10 PST 2016, Paul Walmsley wrote: > On Thu, 25 Feb 2016, Andy Gross wrote: > > > On Thu, Feb 25, 2016 at 08:17:37AM -0800, Bjorn Andersson wrote: > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > --- > > > drivers/soc/qcom/smp2p.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > > index f1eed7f9dd67..61df598444e6 100644 > > > --- a/drivers/soc/qcom/smp2p.c > > > +++ b/drivers/soc/qcom/smp2p.c > > > @@ -379,7 +379,7 @@ static int qcom_smp2p_alloc_outbound_item(struct qcom_smp2p *smp2p) > > > return PTR_ERR(out); > > > } > > > > > > - memset(out, 0, sizeof(*out)); > > > + memset_io(out, 0, sizeof(*out)); > > > out->magic = SMP2P_MAGIC; > > > out->local_pid = smp2p->local_pid; > > > out->remote_pid = smp2p->remote_pid; > > > > Good catch. I'll add this fix for the pull. > > Folks, is qmem_smem_get() intended to return pointers to device-mapped > memory, as implied by this change? > > If so, shouldn't the return type of qmem_smem_get() et al. be void > __iomem * rather than void *? > The shared memory is remapped system ram, so it should not be device mapped. I've discussed this with Andy in the past and we'll try to get the discussions settled during next week's Linaro Connect. Regards, Bjorn ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1456417057-17591-1-git-send-email-bjorn.andersson@linaro.org>
[not found] ` <20160225220224.GA9986@hector.attlocal.net>
2016-03-01 17:10 ` [PATCH] soc: qcom: smp2p: Use memset_io to zero out new entries Paul Walmsley
2016-03-01 17:27 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).