public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding
Date: Wed, 2 Mar 2016 11:53:19 -0600	[thread overview]
Message-ID: <20160302175319.GA11155@rob-hp-laptop> (raw)
In-Reply-To: <1456389222-12738-2-git-send-email-pankaj.dubey@samsung.com>

On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote:
> This patch adds exynos-srom binding information for SROM Controller
> driver on Exynos SoCs.
> 
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
> CC: devicetree at vger.kernel.org
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  .../devicetree/bindings/memory-controllers/exynos-srom.txt   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> new file mode 100644
> index 0000000..33886d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
> @@ -0,0 +1,12 @@
> +SAMSUNG Exynos SoCs SROM Controller driver.
> +
> +Required properties:
> +- compatible : Should contain "samsung,exynos-srom".

There should be SoC specific compatible strings in addition to this.

> +
> +- reg: offset and length of the register set
> +
> +Example:
> +	sromc at 12570000 {

This should be memory-controller at ...

> +		compatible = "samsung,exynos-srom";
> +		reg = <0x12570000 0x10>;

The next patch changes the size to 0x14?

BTW, you could just combine both patches. I guess you didn't to maintain 
authorship?

Rob

  reply	other threads:[~2016-03-02 17:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  8:33 [RESPIN 0/6] Add support for Exynos SROM Controller driver Pankaj Dubey
2016-02-25  8:33 ` [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding Pankaj Dubey
2016-03-02 17:53   ` Rob Herring [this message]
2016-03-05  4:42     ` pankaj.dubey
2016-03-08  7:05       ` Pavel Fedin
2016-04-04  3:35       ` Krzysztof Kozlowski
2016-03-05  6:18     ` pankaj.dubey
2016-03-11  2:39       ` pankaj.dubey
2016-02-25  8:33 ` [RESPIN 2/6] drivers: memory: Add support for exynos SROM driver Pankaj Dubey
2016-02-26  7:25   ` Krzysztof Kozlowski
2016-02-26  7:36     ` Krzysztof Kozlowski
2016-02-25  8:33 ` [RESPIN 3/6] MAINTAINERS: Add maintainers entry for drivers/memory/samsung Pankaj Dubey
2016-02-25  8:33 ` [RESPIN 4/6] ARM: EXYNOS: Remove SROM related register settings from mach-exynos Pankaj Dubey
2016-02-26  7:28   ` Krzysztof Kozlowski
2016-02-25  8:33 ` [RESPIN 5/6] dt-bindings: EXYNOS: Describe SROMc configuration Pankaj Dubey
2016-03-02 17:57   ` Rob Herring
2016-03-05  4:47     ` pankaj.dubey
2016-02-25  8:33 ` [RESPIN 6/6] drivers: memory: exynos-srom: Add support for bank configuration Pankaj Dubey
2016-02-26  7:51 ` [RESPIN 0/6] Add support for Exynos SROM Controller driver Krzysztof Kozlowski
2016-02-26  8:33   ` Pavel Fedin
2016-02-26 10:55     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302175319.GA11155@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox