From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property
Date: Fri, 4 Mar 2016 10:04:38 +0800 [thread overview]
Message-ID: <20160304020438.GC30272@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <56D8BB1D.6040108@maciej.szmigiero.name>
On Thu, Mar 03, 2016 at 11:30:53PM +0100, Maciej S. Szmigiero wrote:
> Hi Peter,
>
> On 03.03.2016 11:01, Peter Chen wrote:
> > From: Peter Chen <peter.chen@freescale.com>
> >
> > The current dts describes USB HUB's property at USB controller's
> > entry, it is improper. The USB HUB should be the child node
> > under USB controller.
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
>
> Thanks for patches!
>
> VID:PID for hub on UDOO board is 0424:2514.
>
> I've tested these patches on this board and was able to make USB work
> again with following DT changes:
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index d3e54e4..4956de7 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -9,6 +9,8 @@
> *
> */
>
> +#include <dt-bindings/gpio/gpio.h>
> +
> / {
> chosen {
> stdout-path = &uart2;
> @@ -18,21 +27,11 @@
> reg = <0x10000000 0x40000000>;
> };
>
> - regulators {
> - compatible = "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - reg_usb_h1_vbus: regulator at 0 {
> - compatible = "regulator-fixed";
> - reg = <0>;
> - regulator-name = "usb_h1_vbus";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - enable-active-high;
> - startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */
> - gpio = <&gpio7 12 0>;
> - };
> + usb2415_pwrseq: usb2415_pwrseq {
> + compatible = "usb-pwrseq";
> + clocks = <&clks IMX6QDL_CLK_CKO>;
> + reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
> + reset-duration-us = <3000>;
> };
>
> sound {
> @@ -163,9 +218,16 @@
> &usbh1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usbh>;
> - vbus-supply = <®_usb_h1_vbus>;
> - clocks = <&clks 201>;
> status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub: usb2415 at 01 {
> + compatible = "usb424,2514";
> + reg = <1>;
> + usb-pwrseq = <&usb2415_pwrseq>;
> + };
> };
>
> &usdhc3 {
>
>
Thank you very much.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-03-04 2:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:01 [PATCH 0/3] Add power sequence for hard-wired USB devices Peter Chen
2016-03-03 10:01 ` [PATCH 1/3] usb: core: add power sequence for " Peter Chen
2016-03-03 18:31 ` Alan Stern
2016-03-04 2:07 ` Peter Chen
2016-03-03 20:54 ` Rob Herring
2016-03-04 2:02 ` Peter Chen
2016-03-04 2:23 ` Andrew Lunn
2016-03-04 2:37 ` Peter Chen
2016-03-05 4:28 ` Rob Herring
2016-03-05 8:33 ` Peter Chen
2016-03-05 14:10 ` Andrew Lunn
2016-03-14 10:42 ` Peter Chen
2016-04-05 9:35 ` Peter Chen
2016-03-03 10:01 ` [PATCH 2/3] usb: chipidea: host: let the hcd know's parent device node Peter Chen
2016-03-03 14:42 ` Andrew Lunn
2016-03-04 1:53 ` Peter Chen
2016-03-04 2:17 ` Andrew Lunn
2016-03-04 2:32 ` Peter Chen
2016-03-03 10:01 ` [PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-03-03 22:30 ` Maciej S. Szmigiero
2016-03-04 2:04 ` Peter Chen [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-08 1:37 [PATCH 0/3] USB: add generic onboard USB HUB driver Peter Chen
2015-12-08 1:37 ` [PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304020438.GC30272@shlinux2.ap.freescale.net \
--to=hzpeterchen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).